-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361964: Remove outdated algorithms from requirements and add PBES2 algorithms #26392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back mullan! A progress list of the required criteria for merging this PR into |
@seanjmullan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 121 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@seanjmullan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Changes look good. |
/integrate |
Going to push as commit 06fdb61.
Your commit was automatically rebased without conflicts. |
@seanjmullan Pushed as commit 06fdb61. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The Security Algorithm Implementation Requirements will be updated as follows:
The following algorithms will be removed from the list of required algorithms as they are no longer recommended, and should not be in wide usage anymore:
The following PBES2 algorithms will be added as new requirements. These are modern password-based encryption, mac and key derivation algorithms defined in PKCS #5 version 2.1 (RFC 8018):
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26392/head:pull/26392
$ git checkout pull/26392
Update a local copy of the PR:
$ git checkout pull/26392
$ git pull https://git.openjdk.org/jdk.git pull/26392/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26392
View PR using the GUI difftool:
$ git pr show -t 26392
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26392.diff
Using Webrev
Link to Webrev Comment