Skip to content

8361964: Remove outdated algorithms from requirements and add PBES2 algorithms #26392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Jul 18, 2025

The Security Algorithm Implementation Requirements will be updated as follows:

The following algorithms will be removed from the list of required algorithms as they are no longer recommended, and should not be in wide usage anymore:

AlgorithmParameters: DESede
Cipher:
    DESede/CBC/NoPadding
    DESede/CBC/PKCS5Padding
    DESede/ECB/NoPadding
    DESede/ECB/PKCS5Padding
    RSA/ECB/PKCS1Padding
KeyGenerator: DESede
SecretKeyFactory: DESede

The following PBES2 algorithms will be added as new requirements. These are modern password-based encryption, mac and key derivation algorithms defined in PKCS #5 version 2.1 (RFC 8018):

AlgorithmParameters:
    PBEWithHmacSHA256AndAES_128
    PBEWithHmacSHA256AndAES_256
Cipher:
    PBEWithHmacSHA256AndAES_128
    PBEWithHmacSHA256AndAES_256
Mac:
    PBEWithHmacSHA256
SecretKeyFactory:
    PBEWithHmacSHA256AndAES_128
    PBEWithHmacSHA256AndAES_256
    PBKDF2WithHmacSHA256

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8362549 to be approved

Issues

  • JDK-8361964: Remove outdated algorithms from requirements and add PBES2 algorithms (Enhancement - P3)
  • JDK-8362549: Remove outdated algorithms from requirements and add PBES2 algorithms (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26392/head:pull/26392
$ git checkout pull/26392

Update a local copy of the PR:
$ git checkout pull/26392
$ git pull https://git.openjdk.org/jdk.git pull/26392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26392

View PR using the GUI difftool:
$ git pr show -t 26392

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26392.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361964: Remove outdated algorithms from requirements and add PBES2 algorithms

Reviewed-by: hchao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 121 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jul 18, 2025
@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@seanjmullan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 18, 2025

Webrevs

@haimaychao
Copy link
Contributor

Changes look good.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 25, 2025
@seanjmullan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2025

Going to push as commit 06fdb61.
Since your change was applied there have been 126 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2025
@openjdk openjdk bot closed this Jul 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2025
@openjdk
Copy link

openjdk bot commented Jul 25, 2025

@seanjmullan Pushed as commit 06fdb61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants