Skip to content

8362572: Delete the usage of "sun.java2d.reftype" from the sun.java2d.Disposer #26394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jul 18, 2025

Just a code cleanup to reduce the amount of code we need to care about, test, and support.

The class sun.java2d.Disposer can use either weak or phantom references. For many years it has used phantom references by default.

One reason why weak references were supported is because phantom references keep a strong reference to the object until the reference is added to the reference queue and cleared. This behavior changed after the fix for JDK-8071507. Now both weak and phantom references behave the same way when it comes to clearing the reference to the object.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362572: Delete the usage of "sun.java2d.reftype" from the sun.java2d.Disposer (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26394/head:pull/26394
$ git checkout pull/26394

Update a local copy of the PR:
$ git checkout pull/26394
$ git pull https://git.openjdk.org/jdk.git pull/26394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26394

View PR using the GUI difftool:
$ git pr show -t 26394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26394.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362572: Delete the usage of "sun.java2d.reftype" from the sun.java2d.Disposer

Reviewed-by: prr, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review July 21, 2025 07:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 21, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2025

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. I checked to see if any tests use this, but didn't find any.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2025
@mrserb
Copy link
Member Author

mrserb commented Jul 22, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

Going to push as commit 7d7d308.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 22, 2025
@openjdk openjdk bot closed this Jul 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@mrserb Pushed as commit 7d7d308.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8362572 branch August 12, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants