-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8210765: Remove finalize method in CStrike.java #26397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
/label remove rfr |
@prrace
|
Remove finalize method from CStrike.java
This one is a bit odd in that there's already a Disposer used - and in fact it involves two classes
CStrikeDisposer.java and its subclass - the nested class CStrike.GlyphInfoCache
CStrike.GlyphInfoCache is tracking all the glyph image references.
CStrikeDisposer has the full set of constructors of its superclass - FontStrikeDisposer including support
for the native context
And if supplied, CStrikeDisposer will call the native method freeNativeScalerContext(long) to free the native context
but that native method does not exist !
And there's no CStrike.GlyphInfoCache constructor which allows it to be specified
So the fix is to add that and call the disposeNativeStrikePtr method instead.
I also rejigged things a little so nativeStrikePtr could be final which is supposed to help with the thread visibility.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26397/head:pull/26397
$ git checkout pull/26397
Update a local copy of the PR:
$ git checkout pull/26397
$ git pull https://git.openjdk.org/jdk.git pull/26397/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26397
View PR using the GUI difftool:
$ git pr show -t 26397
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26397.diff
Using Webrev
Link to Webrev Comment