8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note

[Korov]

Free the buf before the early return.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer) Review applies to bf535406
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26403/head:pull/26403
$ git checkout pull/26403

Update a local copy of the PR:
$ git checkout pull/26403
$ git pull https://git.openjdk.org/jdk.git pull/26403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26403

View PR using the GUI difftool:
$ git pr show -t 26403

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26403.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Korov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Korov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note

Reviewed-by: dholmes, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• fd7f78a: 8362493: Cleanup CodeBuffer::copy_relocations_to
• 1b94a34: 8362836: JFR: Broken pipe in jdk/jfr/event/io/TestIOTopFrame.java
• 13bab09: 8362532: Test gc/g1/plab/* duplicate command-line options
• ... and 5 more: https://git.openjdk.org/jdk/compare/441dbde2c3c915ffd916e39a5b4a91df5620d7f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@Korov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (470a463c)
• 00: Full (bf535406)

[openjdk]

⚠️ @Korov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8362611
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

[dholmes-ora]

Thanks for the update.

[Korov]

/integrate

[openjdk]

@Korov
Your change (at version 470a463) is now ready to be sponsored by a Committer.

[MBaesken]

/sponsor

[openjdk]

Going to push as commit 644e400.
Since your change was applied there have been 8 commits pushed to the master branch:

• fd7f78a: 8362493: Cleanup CodeBuffer::copy_relocations_to
• 1b94a34: 8362836: JFR: Broken pipe in jdk/jfr/event/io/TestIOTopFrame.java
• 13bab09: 8362532: Test gc/g1/plab/* duplicate command-line options
• ... and 5 more: https://git.openjdk.org/jdk/compare/441dbde2c3c915ffd916e39a5b4a91df5620d7f3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken @Korov Pushed as commit 644e400.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.