8362898: Remove finalize() methods from javax.imageio TIFF classes

[prrace]

Remove finalize from TIFF ImageIO implementatation classes.

Following copied from the bug description
The TIFF image (de)compressors can make use of a JPEG reader / writer
Like all ImageIO readers and writers, once done, the owner should call their dispose() method.
This is currently done with finalize() to ensure it isn't missed.

This can be migrated to a Disposer.

However, the most common case is that it is the ImageIO built-in JPEGImageReader and JPEGImageWriter
that is located and that already implements a Disposer. So there is no need to add a Disposer for that.
We only need to add it if we find some other reader/writer.

With enough work, it might be possible for the TIFF compressor/decompressor classes to work out when
they are really done and avoid a Disposer at all. But it could also be that they instead need to discard
them when a specific task is done and then obtain a new one.
That would be much more overhead than just adding a Disposer for the rare case and regardless
of what is done in the TIFF code, the built in JPEG classes will install their own Disposer so I don't
think I want to pursue that route.

I also noticed that TIFFBaseJPEGCompressor.java can replace the current writer if it doesn't satisfy a need.
In that case it just nulls it out and doesn't call dispose() and of course finalize() will then refer to the replacement.
So I added direct calls to dispose() in such a case. That was definitely necessary with the finalize() code
but the Disposer would have taken care of it anyway, so it isn't strictly needed with the new code but
it is still good to do it early if you can.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362898: Remove finalize() methods from javax.imageio TIFF classes (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Jayathirth D V (@jayathirthrao - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26416/head:pull/26416
$ git checkout pull/26416

Update a local copy of the PR:
$ git checkout pull/26416
$ git pull https://git.openjdk.org/jdk.git pull/26416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26416

View PR using the GUI difftool:
$ git pr show -t 26416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26416.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362898: Remove finalize() methods from javax.imageio TIFF classes

Reviewed-by: azvegint, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 181 new commits pushed to the master branch:

• 0d0d93e: 8210765: Remove finalize method in CStrike.java
• d1e362e: 8363889: Update sun.print.PrintJob2D to use Disposer
• 05f8a6f: 8360559: Optimize Math.sinh for x86 64 bit platforms
• ... and 178 more: https://git.openjdk.org/jdk/compare/d83346dcff0824575d580ec421476c0ea5c6e783...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (be0168c6)

[prrace]

/integrate

[openjdk]

@prrace This pull request has not yet been marked as ready for integration.

[prrace]

/integrate

[openjdk]

@prrace This pull request has not yet been marked as ready for integration.

[prrace]

/integrate

[openjdk]

Going to push as commit dc4d9b4.
Since your change was applied there have been 182 commits pushed to the master branch:

• da3a5da: 8343218: Add option to disable allocating interface and abstract classes in non-class metaspace
• 0d0d93e: 8210765: Remove finalize method in CStrike.java
• d1e362e: 8363889: Update sun.print.PrintJob2D to use Disposer
• ... and 179 more: https://git.openjdk.org/jdk/compare/d83346dcff0824575d580ec421476c0ea5c6e783...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit dc4d9b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.