-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java #26431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java #26431
Conversation
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@justin-curtis-lu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@wangweij When you have the chance, are you able to review this issue you already reviewed in mainline. It is a test-only issue and eligible for backport to JDK25. TIA! |
@justin-curtis-lu If you plan to integrate this, please do so before the RC build, which is on Aug 7. |
Thanks for the review. |
Going to push as commit 9bdf9eb.
Your commit was automatically rebased without conflicts. |
@justin-curtis-lu Pushed as commit 9bdf9eb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which is a backport of commit 5540a785 from the openjdk/jdk repository.
This is a test-only issue which removes an incorrect l10n test case.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26431/head:pull/26431
$ git checkout pull/26431
Update a local copy of the PR:
$ git checkout pull/26431
$ git pull https://git.openjdk.org/jdk.git pull/26431/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26431
View PR using the GUI difftool:
$ git pr show -t 26431
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26431.diff
Using Webrev
Link to Webrev Comment