Skip to content

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jul 22, 2025

Please review this PR which is a backport of commit 5540a785 from the openjdk/jdk repository.

This is a test-only issue which removes an incorrect l10n test case.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26431/head:pull/26431
$ git checkout pull/26431

Update a local copy of the PR:
$ git checkout pull/26431
$ git pull https://git.openjdk.org/jdk.git pull/26431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26431

View PR using the GUI difftool:
$ git pr show -t 26431

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26431.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2025

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java

Reviewed-by: hchao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the jdk25 branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5540a7859b3ae0faf6b6c7f50e53ff611b253a9f 8360416: Incorrect l10n test case in sun/security/tools/keytool/i18n.java Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@justin-curtis-lu The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 22, 2025

Webrevs

@justin-curtis-lu
Copy link
Member Author

@wangweij When you have the chance, are you able to review this issue you already reviewed in mainline. It is a test-only issue and eligible for backport to JDK25. TIA!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 31, 2025
@kevinrushforth
Copy link
Member

@justin-curtis-lu If you plan to integrate this, please do so before the RC build, which is on Aug 7.

@justin-curtis-lu
Copy link
Member Author

Thanks for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2025

Going to push as commit 9bdf9eb.
Since your change was applied there have been 6 commits pushed to the jdk25 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2025
@openjdk openjdk bot closed this Aug 1, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2025
@openjdk
Copy link

openjdk bot commented Aug 1, 2025

@justin-curtis-lu Pushed as commit 9bdf9eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated security [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants