8362581: Timeouts in java/nio/channels/SocketChannel/OpenLeak.java on UNIX

[Michael-Mc-Mahon]

Hi,

This is a fix for 8362581 caused by the implementation for https://bugs.openjdk.org/browse/JDK-8348986
An incorrect check was added to the method Exceptions.ioException() which wasn't noticed partly
because that file was renamed, and webrev doesn't show the diffs side by side.
The effect of this change is to restore the method to pretty much what it was before, but taking account
of the changed categorisation of exceptions.

A test is not included since this was caught by an existing regression test.

Thanks,
Michael

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362581: Timeouts in java/nio/channels/SocketChannel/OpenLeak.java on UNIX (Bug - P4)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer) Review applies to 45cb3a46
• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26478/head:pull/26478
$ git checkout pull/26478

Update a local copy of the PR:
$ git checkout pull/26478
$ git pull https://git.openjdk.org/jdk.git pull/26478/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26478

View PR using the GUI difftool:
$ git pr show -t 26478

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26478.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Michael-Mc-Mahon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362581: Timeouts in java/nio/channels/SocketChannel/OpenLeak.java on UNIX

Reviewed-by: jpai, alanb, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 9e209fe: 8364110: Remove unused methods in GCCause
• 75ff7e1: 8361712: Improve ShenandoahAsserts printing
• 06fdb61: 8361964: Remove outdated algorithms from requirements and add PBES2 algorithms

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@Michael-Mc-Mahon The following labels will be automatically applied to this pull request:

• core-libs
• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c9a05bd6)
• 00: Full (45cb3a46)

[AlanBateman]

/label remove core-libs
/label add net

[openjdk]

@AlanBateman
The core-libs label was successfully removed.

[openjdk]

@AlanBateman
The net label was successfully added.

[AlanBateman]

I think you can drop this change to the test, it only accidentally uncovered this issue.

[jaikiran]

This looks good to me. I've verified that with this change, the timing for the test methods in test/jdk/java/nio/channels/SocketChannel/OpenLeak.java drops back to the same duration that was there before the changes that were done in https://bugs.openjdk.org/browse/JDK-8348986

[Michael-Mc-Mahon]

/integrate

[openjdk]

Going to push as commit de59da2.
Since your change was applied there have been 6 commits pushed to the master branch:

• d288ca2: 8358048: java/net/httpclient/HttpsTunnelAuthTest.java incorrectly calls Thread::stop
• e756c0d: 8361726: Shenandoah: More detailed evacuation instrumentation
• 89fe586: 8363837: Make StubRoutines::crc_table_adr() into platform-specific method
• ... and 3 more: https://git.openjdk.org/jdk/compare/41c94eed37aad570229ee2c5fb51d9e5d0378a40...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Michael-Mc-Mahon Pushed as commit de59da2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.