8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64

[theaoqi]

After JDK-8329004, the following code was added.

#ifndef PNG_LOONGARCH_LSX_OPT
# if defined(__loongarch_sx)
# define PNG_LOONGARCH_LSX_OPT 1
# else
# define PNG_LOONGARCH_LSX_OPT 0
# endif
#endif

Some compilers on LoongArch64 platforms enable __loongarch_sx, which causes PNG_LOONGARCH_LSX_OPT to be defined and an undefined error occurs. Refer to JDK-8078245, add -DPNG_LOONGARCH_LSX_OPT=0 to LIBSPLASHSCREEN_CFLAGS flags.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64 (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26501/head:pull/26501
$ git checkout pull/26501

Update a local copy of the PR:
$ git checkout pull/26501
$ git pull https://git.openjdk.org/jdk.git pull/26501/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26501

View PR using the GUI difftool:
$ git pr show -t 26501

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26501.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@theaoqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364177: JDK fails to build due to undefined symbol in libpng on LoongArch64

Reviewed-by: prr, aivanov, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• 7ea08d3: 8362244: Devkit's Oracle Linux base OS keyword is incorrectly documented
• 8e921ae: 8364370: java.text.DecimalFormat specification indentation correction
• 6d0bbc8: 8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase
• ... and 72 more: https://git.openjdk.org/jdk/compare/011de4c894ed827ee8e15a7cfe400788175e5b2c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @aivanov-jdk, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@theaoqi The following labels will be automatically applied to this pull request:

• build
• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2078e5eb)

[prrace]

If PNG_LOONGARCH_LSX_OPT is set to 0 it disables all those extra fns
https://github.com/openjdk/jdk/pull/18964/files

So LGTM.

[theaoqi]

Thanks for the review, @prrace. Is a second reviewer needed?

[prrace]

Thanks for the review, @prrace. Is a second reviewer needed?

I think wait another day to see if anyone from the build team wants to look.
@magicus ?

[aivanov-jdk]

Looks good to me too.

As Phil suggested, you should wait for a day or two if anyone from the build team takes a look.

[theaoqi]

Thanks for the reviews!
/integrate

[openjdk]

@theaoqi
Your change (at version 2078e5e) is now ready to be sponsored by a Committer.

[theaoqi]

Could any committer please help to sponsor this patch?

[erikj79]

/sponsor

[openjdk]

Going to push as commit a9f3d3a.
Since your change was applied there have been 91 commits pushed to the master branch:

• 500462f: 8364580: Test compiler/vectorization/TestSubwordTruncation.java fails on platforms without RoundF/RoundD
• 68a4396: 8364316: JFR: Incorrect validation of mirror fields
• da0d959: 8364190: JFR: RemoteRecordingStream withers don't work
• ... and 88 more: https://git.openjdk.org/jdk/compare/011de4c894ed827ee8e15a7cfe400788175e5b2c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@erikj79 @theaoqi Pushed as commit a9f3d3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[theaoqi]

@erikj79, thanks!