Skip to content

Conversation

driverkt
Copy link
Member

@driverkt driverkt commented Jul 28, 2025

Enhance the memory management/cleanup for ECDSASignature.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364226: Better ECDSASignature Memory Management (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26516/head:pull/26516
$ git checkout pull/26516

Update a local copy of the PR:
$ git checkout pull/26516
$ git pull https://git.openjdk.org/jdk.git pull/26516/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26516

View PR using the GUI difftool:
$ git pr show -t 26516

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26516.diff

Using Webrev

Link to Webrev Comment

@driverkt driverkt marked this pull request as draft July 28, 2025 20:00
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2025

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 28, 2025

@driverkt This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364226: Better ECDSASignature Memory Management

Reviewed-by: ascarpino, hchao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jul 28, 2025

@driverkt The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@driverkt driverkt marked this pull request as ready for review July 28, 2025 23:39
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2025

Webrevs

@driverkt driverkt requested a review from ascarpino August 1, 2025 16:22
Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Thanks.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2025
@haimaychao
Copy link
Contributor

Looks good.

@driverkt
Copy link
Member Author

driverkt commented Aug 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2025

Going to push as commit b5f450a.
Since your change was applied there have been 86 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2025
@openjdk openjdk bot closed this Aug 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2025
@openjdk
Copy link

openjdk bot commented Aug 4, 2025

@driverkt Pushed as commit b5f450a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@driverkt driverkt deleted the 8364226 branch August 4, 2025 16:00
@driverkt
Copy link
Member Author

driverkt commented Aug 4, 2025

/backport

@openjdk
Copy link

openjdk bot commented Aug 4, 2025

@driverkt Usage: /backport <repository> [<branch>] or /backport [<repository>]:<branch>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security [email protected]
Development

Successfully merging this pull request may close these issues.

3 participants