Skip to content

8364230: javax/swing/text/StringContent can be migrated away from using finalize #26519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

8364230: javax/swing/text/StringContent can be migrated away from using finalize #26519

wants to merge 3 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Jul 28, 2025 •
edited by openjdk bot
Loading

Convert StringContent's Position usage tracking to use a WeakReference

The test that is added only implicitly tests this but I added it because of a complete lack of any test for this code.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364230: javax/swing/text/StringContent can be migrated away from using finalize (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26519/head:pull/26519
$ git checkout pull/26519

Update a local copy of the PR:
$ git checkout pull/26519
$ git pull https://git.openjdk.org/jdk.git pull/26519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26519

View PR using the GUI difftool:
$ git pr show -t 26519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26519.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 28, 2025 •
edited
Loading

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364230: javax/swing/text/StringContent can be migrated away from using finalize

Reviewed-by: psadhukhan, abhiscxk, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 145 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8364230 8364230: javax/swing/text/StringContent can be migrated away from using finalize Jul 28, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2025
@openjdk
Copy link

openjdk bot commented Jul 28, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jul 28, 2025 •
edited
Loading

Webrevs

kumarabhi006
kumarabhi006 reviewed Aug 1, 2025
View reviewed changes
test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java Outdated
Comment on lines 36 to 38
static final String text = "hello";
static final int LEN = text.length();
static final StringContent st = new StringContent();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, static final variables can be capitalized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK ... and it made me notice I wasn't using text/TEXT - fixed that

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2025
prsadhuk
prsadhuk reviewed Aug 6, 2025
View reviewed changes
test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java Outdated
st.insertString(0, "hello");
positions[i] = st.createPosition(5);
SC.insertString(0, TEXT);
positions[i] = SC.createPosition(5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be LEN instead of 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. fixed

test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java
@@ -33,9 +33,9 @@
public class StringContentPositionTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @bug is not added because this is not strictly a regression test for this issue as I see it does not fail even without the fix?
Since System.gc is used, can we try restricting the heap size in commandline to see if it will fail without the fix and pass with it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't fail either way. I just changed how the clean up was done.
And GC is kicking in anyway with default settings.
So no point on both counts.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 6, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 7, 2025
@prrace
Copy link
Contributor Author

prrace commented Aug 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2025

Going to push as commit 78117ef.
Since your change was applied there have been 155 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2025
@openjdk openjdk bot closed this Aug 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2025
@openjdk
Copy link

openjdk bot commented Aug 7, 2025

@prrace Pushed as commit 78117ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
5 more reviewers

@turbanoff turbanoff turbanoff left review comments

@myankelev myankelev myankelev left review comments

@prsadhuk prsadhuk prsadhuk approved these changes

@azuev-java azuev-java azuev-java approved these changes

@kumarabhi006 kumarabhi006 kumarabhi006 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
client [email protected] integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prrace @turbanoff @prsadhuk @azuev-java @kumarabhi006 @myankelev