8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index #26522

jayathirthrao · 2025-07-29T05:38:00Z

We need to throw appropriate exception when we pass invalid image index values to ImageReader.getImageTypes().
We throw IOOBE in all other plugins except JPEG, Added appropriate check to throw IOOBE when JpegImageReader has invalid image index.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index (Bug - P4)

Reviewers

Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26522/head:pull/26522
$ git checkout pull/26522

Update a local copy of the PR:
$ git checkout pull/26522
$ git pull https://git.openjdk.org/jdk.git pull/26522/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26522

View PR using the GUI difftool:
$ git pr show -t 26522

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26522.diff

Using Webrev

Link to Webrev Comment

…on-zero image index

bridgekeeper · 2025-07-29T05:38:43Z

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-07-29T05:39:32Z

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 158 new commits pushed to the master branch:

5274725: 8154364: (fs) Files.isSameFile() throws NoSuchFileException with broken symbolic links
11eccfc: 8365917: Sort share/logging includes
bdf9834: 8365425: [macos26] javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java fails on macOS 26
... and 155 more: https://git.openjdk.org/jdk/compare/241808e13fb032b0ec192e0b7ff94891a653ac94...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-07-29T05:40:09Z

@jayathirthrao The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-07-29T05:44:04Z

Webrevs

01: Full - Incremental (a114acf4)
00: Full (cfc24f34)

prrace · 2025-07-29T17:22:09Z

src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java

@@ -902,6 +902,9 @@ public ImageTypeSpecifier getRawImageType(int imageIndex)
    @Override
    public Iterator<ImageTypeSpecifier> getImageTypes(int imageIndex)
        throws IOException {
+        if (imageIndex != 0) {
+            throw new IndexOutOfBoundsException("imageIndex != 0!");
+        }


There are JPEG streams with > 1.
And elsewhere we handle it. Look at hasNextImage()

Is this method the sole place where -1 would not throw the right exception ?

Thanks for the inputs.

getWidth(), getHeight(), getRawImageType() also need similar check.
What i have noticed is for all negative indices apart from "-1" we end up in gotoImage() function and it throws appropriate exception. Only getWidth(), getHeight(), getRawImageType() & getImageTypes() we don't throw proper exception according to spec when "-1" index is used. Also in case of getRawImageType() we actually throw NPE when "-1" index is passed.

So i have updated the code to add additional check for negative index at these places also.

test/jdk/javax/imageio/plugins/jpeg/JpegNegativeImageIndexTest.java

prrace · 2025-08-21T20:46:41Z

test/jdk/javax/imageio/plugins/jpeg/JpegNegativeImageIndexTest.java

+            int height = ir.getHeight(-1);
+            ImageTypeSpecifier specifier = ir.getRawImageType(-1);
+        } catch (IndexOutOfBoundsException e) {
+            if (Objects.equals(e.getMessage(), "imageIndex < 0")) {


A bit fragile checking the exception text, but I suppose it won't be changed unless this test changes too.

prsadhuk · 2025-08-22T07:13:45Z

src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java

@@ -391,6 +391,12 @@ private void checkTablesOnly() throws IOException {
        tablesOnlyChecked = true;
    }

+    private void checkNegativeImageIndex(int imageIndex) {
+        if (imageIndex < minIndex) {
+            throw new IndexOutOfBoundsException("imageIndex < " + minIndex);


Should we irrespectively throw IOBE or check for seekForwardOnly before throwing the exception

jdk/src/java.desktop/share/classes/javax/imageio/ImageReader.java

Lines 228 to 235 in f423e1d

* <p> The {@code seekForwardOnly} parameter controls whether

* the value returned by {@code getMinIndex} will be

* increased as each image (or thumbnail, or image metadata) is

* read. If {@code seekForwardOnly} is true, then a call to

* {@code read(index)} will throw an

* {@code IndexOutOfBoundsException} if {@code index < this.minIndex};

* otherwise, the value of

* {@code minIndex} will be set to {@code index}. If

8364135: JPEGImageReader.getImageTypes() should throw exception for n…

cfc24f3

…on-zero image index

openjdk bot added the rfr Pull request is ready for review label Jul 29, 2025

openjdk bot added the client [email protected] label Jul 29, 2025

prrace reviewed Jul 29, 2025

View reviewed changes

alisenchung reviewed Aug 1, 2025

View reviewed changes

test/jdk/javax/imageio/plugins/jpeg/JpegNegativeImageIndexTest.java Show resolved Hide resolved

jayathirthrao changed the title ~~8364135: JPEGImageReader.getImageTypes() should throw exception for non-zero image index~~ 8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index Aug 20, 2025

jayathirthrao marked this pull request as draft August 20, 2025 05:24

Check only for negative index

515a1a3

openjdk bot removed the rfr Pull request is ready for review label Aug 20, 2025

jayathirthrao added 3 commits August 20, 2025 10:56

Merge remote-tracking branch 'upstream/master' into jpeg_getImageTypes

5f02b8b

Add checks at other places also

be8d9f0

Update test to handle all regression cases

a114acf

jayathirthrao marked this pull request as ready for review August 21, 2025 04:55

openjdk bot added the rfr Pull request is ready for review label Aug 21, 2025

jayathirthrao requested a review from prrace August 21, 2025 05:04

prrace approved these changes Aug 21, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 21, 2025

prsadhuk reviewed Aug 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index #26522

8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index #26522

jayathirthrao commented Jul 29, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jul 29, 2025

Uh oh!

openjdk bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Jul 29, 2025

Uh oh!

mlbridge bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

prrace Jul 29, 2025

Uh oh!

jayathirthrao Aug 21, 2025

Uh oh!

Uh oh!

prrace Aug 21, 2025

Uh oh!

prsadhuk Aug 22, 2025

Uh oh!

Uh oh!

	* <p> The {@code seekForwardOnly} parameter controls whether
	* the value returned by {@code getMinIndex} will be
	* increased as each image (or thumbnail, or image metadata) is
	* read. If {@code seekForwardOnly} is true, then a call to
	* {@code read(index)} will throw an
	* {@code IndexOutOfBoundsException} if {@code index < this.minIndex};
	* otherwise, the value of
	* {@code minIndex} will be set to {@code index}. If

8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index #26522

Are you sure you want to change the base?

8364135: JPEGImageReader.getImageTypes() should throw exception for negative image index #26522

Conversation

jayathirthrao commented Jul 29, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 29, 2025

Uh oh!

openjdk bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jul 29, 2025

Uh oh!

mlbridge bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

prrace Jul 29, 2025

Choose a reason for hiding this comment

Uh oh!

jayathirthrao Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prrace Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

prsadhuk Aug 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jayathirthrao commented Jul 29, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jul 29, 2025 •

edited

Loading

mlbridge bot commented Jul 29, 2025 •

edited

Loading