-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8294074: Make other specs more discoverable from the API docs #26547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
@hns This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 37 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
<p><a href="../specs/index.html">Related documents</a> specify the Java language, \ | ||
the Java virtual machine, and various tools, protocols, and file formats pertaining \ | ||
to the Java platform.</p> \ | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hns Is this wording that is agreed elsewhere or are you open to suggestions on how this should be worded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wording is what we came up with in internal discussion, but certainly open to suggestions. I created this PR to make the process more transparent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimally, I would not refer to the narrative specs which are part of the platform as "Related documents" since that makes them sound weakly advisory/informational. Perhaps something like "[Additional specifications][../specs/index.html] for the Java language...".
Also, if you're going to provide a link to the narrative specs, I'd also consider adding a reference to the external spec page (https://download.java.net/java/early_access/jdk25/docs/api/external-specs.html).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first word after “related documents” is “specify,” which doesn’t sound advisory to me.
I don’t think the external spec page is of sufficiently broad interest to highlight it here.
(To imply that our tool man pages are “specifications” is a bit much, but making that distinction isn’t worth the trouble here.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about that external spec page. Thanks!
/integrate |
Going to push as commit 7d63c9f.
Your commit was automatically rebased without conflicts. |
Please review a doc-only change to the API overview page to make other specs more discoverable. The following sentence is added at the end of the overview text:
The first sentence of the overview text is also rephrased.
The new API overview page can be viewed here.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26547/head:pull/26547
$ git checkout pull/26547
Update a local copy of the PR:
$ git checkout pull/26547
$ git pull https://git.openjdk.org/jdk.git pull/26547/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26547
View PR using the GUI difftool:
$ git pr show -t 26547
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26547.diff
Using Webrev
Link to Webrev Comment