Skip to content

[PATCH] Pattern matching of instanceof in java.desktop shared code #26662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Aug 6, 2025

Applied changes only to share code to reduce scope of review.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26662/head:pull/26662
$ git checkout pull/26662

Update a local copy of the PR:
$ git checkout pull/26662
$ git pull https://git.openjdk.org/jdk.git pull/26662/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26662

View PR using the GUI difftool:
$ git pr show -t 26662

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26662.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 6, 2025

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@turbanoff turbanoff force-pushed the instanceof_pattern_java.desktop_shared branch from c25606b to 80d3a6f Compare August 6, 2025 19:06
@@ -197,8 +197,7 @@ private void doProperty(Class<?> type, PropertyDescriptor pd, Object oldInstance
if (!Objects.equals(newValue, out.get(oldValue))) {
// Search for a static constant with this value;
Object e = (Object[])pd.getValue("enumerationValues");
if (e instanceof Object[] && Array.getLength(e) % 3 == 0) {
Object[] a = (Object[])e;
if (e instanceof Object[] a && Array.getLength(e) % 3 == 0) {
Copy link
Member Author

@turbanoff turbanoff Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something strange is going on here. In previous line we casted expression to Object[], but assigned to Object type. And here we check if value is really Object[]

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@turbanoff The following labels will be automatically applied to this pull request:

  • client
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link

openjdk bot commented Aug 6, 2025

@turbanoff Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant