-
Notifications
You must be signed in to change notification settings - Fork 6.2k
[PATCH] Pattern matching of instanceof in java.desktop shared code #26662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[PATCH] Pattern matching of instanceof in java.desktop shared code #26662
Conversation
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
c25606b
to
80d3a6f
Compare
@@ -197,8 +197,7 @@ private void doProperty(Class<?> type, PropertyDescriptor pd, Object oldInstance | |||
if (!Objects.equals(newValue, out.get(oldValue))) { | |||
// Search for a static constant with this value; | |||
Object e = (Object[])pd.getValue("enumerationValues"); | |||
if (e instanceof Object[] && Array.getLength(e) % 3 == 0) { | |||
Object[] a = (Object[])e; | |||
if (e instanceof Object[] a && Array.getLength(e) % 3 == 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something strange is going on here. In previous line we casted expression to Object[]
, but assigned to Object
type. And here we check if value is really Object[]
@turbanoff The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@turbanoff Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Applied changes only to share code to reduce scope of review.
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26662/head:pull/26662
$ git checkout pull/26662
Update a local copy of the PR:
$ git checkout pull/26662
$ git pull https://git.openjdk.org/jdk.git pull/26662/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26662
View PR using the GUI difftool:
$ git pr show -t 26662
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26662.diff