8365291: Remove finalize() method from sun/awt/X11InputMethodBase.java

[prrace]

It seems that finalize() in X11InputMethodBase.java isn't useful.
It calls dispose(), which in all actual implementations has just one native resource to release, which
is a native struct of type X11InputMethodData (this is a JDK-defined struct, not one from Xim),
and one of the fields is a JNI GlobalRef pointing to the XInputMethod instance which implements the dispose() method.
So finalize cannot be called unless dispose() is called first. But if dispose() has been called then there's no need for
finalize() since all it does is call dispose()

Many more details in JBS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365291: Remove finalize() method from sun/awt/X11InputMethodBase.java (Bug - P4)

Reviewers

• Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26751/head:pull/26751
$ git checkout pull/26751

Update a local copy of the PR:
$ git checkout pull/26751
$ git pull https://git.openjdk.org/jdk.git pull/26751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26751

View PR using the GUI difftool:
$ git pr show -t 26751

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26751.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365291: Remove finalize() method from sun/awt/X11InputMethodBase.java

Reviewed-by: tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 25480f0: 8365184: sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java Re-enable SerialGC flag on debuggee process
• 636c61a: 8365302: RISC-V: compiler/loopopts/superword/TestAlignVector.java fails when vlen=128

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6aa7db46)

[TejeshR13]

LGTM.

[TejeshR13]

Minor one, have to update copyright.