Skip to content

8365198: Remove unnecessary mention of finalize in ImageIO reader/writer docs #26753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Aug 12, 2025

Image I/O's ImageReader and ImageWriter have never had finalize() methods, yet have a gratuitous mention of finalize(). This should be removed. Simple doc only change

CSR for review : https://bugs.openjdk.org/browse/JDK-8365410


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8365410 to be approved

Issues

  • JDK-8365198: Remove unnecessary mention of finalize in ImageIO reader/writer docs (Bug - P4)
  • JDK-8365410: Remove unnecessary mention of finalize in ImageIO reader/writer docs (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26753/head:pull/26753
$ git checkout pull/26753

Update a local copy of the PR:
$ git checkout pull/26753
$ git pull https://git.openjdk.org/jdk.git pull/26753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26753

View PR using the GUI difftool:
$ git pr show -t 26753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26753.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8365198 8365198: Remove unnecessary mention of finalize in ImageIO reader/writer docs Aug 12, 2025
@openjdk
Copy link

openjdk bot commented Aug 12, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client [email protected] rfr Pull request is ready for review labels Aug 12, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2025

Webrevs

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants