8365436: ImageReaderTest fails when jmods directory not present

[david-beaumont]

Changed test helper creation to know about linkable images, and changed how test skipping is reported (JUnit doesn't honor TestSkippedException, only TestAbortedException).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365436: ImageReaderTest fails when jmods directory not present (Bug - P4)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26774/head:pull/26774
$ git checkout pull/26774

Update a local copy of the PR:
$ git checkout pull/26774
$ git pull https://git.openjdk.org/jdk.git pull/26774/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26774

View PR using the GUI difftool:
$ git pr show -t 26774

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26774.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@david-beaumont This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365436: ImageReaderTest fails when jmods directory not present

Reviewed-by: sgehwolf, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• dbae90c: 8364723: Sort share/interpreter includes
• 059b49b: 8365244: Some test control variables are undocumented in doc/testing.md
• b6d5f49: 8365296: Build failure with Clang due to -Wformat warning after JDK-8364611
• ... and 28 more: https://git.openjdk.org/jdk/compare/f3b34d32d6ea409f8c8f0382e8f01e746366f842...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa, @AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@david-beaumont The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0eac6a0a)

[jerboaa]

Looks good to me. This does the right thing for both builds. JEP 493-enabled and builds with JMODs. Thanks.

[david-beaumont]

/integrate

[openjdk]

@david-beaumont
Your change (at version 0eac6a0) is now ready to be sponsored by a Committer.

[sendaoYan]

/sponsor

[openjdk]

Going to push as commit e7ca8c7.
Since your change was applied there have been 40 commits pushed to the master branch:

• f364fca: 8359119: Change Charset to use StableValue
• bd65d48: 8365245: Move size reducing operations to GrowableArrayWithAllocator
• 57210af: 8365555: Cleanup redundancies in jpackage implementation
• ... and 37 more: https://git.openjdk.org/jdk/compare/f3b34d32d6ea409f8c8f0382e8f01e746366f842...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan @david-beaumont Pushed as commit e7ca8c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.