8365533: Remove outdated jdk.internal.javac package export to several modules from java.base

[jaikiran]

Can I please get a review of these change which removes the outdated use of jdk.internal.javac.ParticipatesInPreview and the qualified export of jdk.internal.javac package? This addresses https://bugs.openjdk.org/browse/JDK-8365533.

These qualified exports in java.base were added in https://bugs.openjdk.org/browse/JDK-8308753 when ClassFile API was in preview. Starting Java 24, ClassFile API is now a part of Java SE. These affected modules don't use any other preview feature, so there's no longer a need to export the jdk.internal.javac package to these modules.

tier1, tier2 and tier3 testing of this change completed without any related failures.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365533: Remove outdated jdk.internal.javac package export to several modules from java.base (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer) Review applies to 90cebe7c
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26776/head:pull/26776
$ git checkout pull/26776

Update a local copy of the PR:
$ git checkout pull/26776
$ git pull https://git.openjdk.org/jdk.git pull/26776/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26776

View PR using the GUI difftool:
$ git pr show -t 26776

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26776.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365533: Remove outdated jdk.internal.javac package export to several modules from java.base

Reviewed-by: alanb, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• f364fca: 8359119: Change Charset to use StableValue

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following labels will be automatically applied to this pull request:

• compiler
• core-libs
• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full (bc083cb3)
• 00: Full (90cebe7c)

[ExE-Boss]

See also #26765 (JDK‑8365416)

[jaikiran]

See also #26765 (JDK‑8365416)

Right, that's what prompted me to start looking into this. The java.desktop change for which that other PR is open can go ahead independently.

[liach]

Looks right to me. However since your changed lines is directly by the java.desktop changed line, there's a conflict and you must resolve it.

[liach]

In addition, PreviewFeature.Feature enum has a few obsolete entries - they should be kept until the preview feature is not in the minimum boot JDK. Now the boot JDK is min 24, and a few of the features are already permanent in 24.

[openjdk]

@jaikiran this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8365533
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[jaikiran]

Thank you Alan and Chen for the reviews.

tier1, tier2 and tier3 testing with this change completed without any related issues.

In addition, PreviewFeature.Feature enum has a few obsolete entries ... Now the boot JDK is min 24, and a few of the features are already permanent in 24.

I'll file a separate issue to clean those up.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 81c6ed3.
Since your change was applied there have been 9 commits pushed to the master branch:

• c1198bb: 8357277: Update OpenSSL library for interop tests
• a42ba1f: 8365638: JFR: Add --exact for debugging out-of-order events
• 6e91ccd: 8365305: The ARIA role ‘contentinfo’ is not valid for the element
• ... and 6 more: https://git.openjdk.org/jdk/compare/bd65d483df4742bb7ce79b613f10f70a45117f84...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 81c6ed3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jaikiran]

In addition, PreviewFeature.Feature enum has a few obsolete entries ... Now the boot JDK is min 24, and a few of the features are already permanent in 24.

I'll file a separate issue to clean those up.

I've now filed https://bugs.openjdk.org/browse/JDK-8365699 to track this.