8366896: JFR: Add gc view support for ZGC #27099
Open
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could I have a review of a PR that fixes the 'jfr gc view' when using ZGC?
The problem is that jdk.YoungGarbageCollection and jdk.OldGarbageCollection events are not used with ZGC. Instead, jdk.ZYoungGarbageCollection and jdk.ZOldGarbageCollection are used.
Before:
$ jfr view gc recording.jfr
After:
$ jfr view gc recording.jfr
Note: "Unknown" can still occur if not all events for a GC ID have been emitted.
I also made a change so that GCs are now ordered according to GC ID. This prevents issues where entries with a start time of N/A appear first in cases where not all events are emitted for a GC cycle.
Testing: jdk/jdk/jfr + manual inspection with ZGC, G1, Parallel and Serial.
Thanks
Erik
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27099/head:pull/27099
$ git checkout pull/27099
Update a local copy of the PR:
$ git checkout pull/27099
$ git pull https://git.openjdk.org/jdk.git pull/27099/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27099
View PR using the GUI difftool:
$ git pr show -t 27099
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27099.diff
Using Webrev
Link to Webrev Comment