-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8366522: CodeSource.getCodeSigners() throws NPE within empty certs #27105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8366522: CodeSource.getCodeSigners() throws NPE within empty certs #27105
Conversation
/covered |
Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
❗ This change is not yet ready to be integrated. |
@kirill-shirokov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 minor comment scratch that, I'm confused :D
@kirill-shirokov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
The new tests cover only NPE scenarios.
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27105/head:pull/27105
$ git checkout pull/27105
Update a local copy of the PR:
$ git checkout pull/27105
$ git pull https://git.openjdk.org/jdk.git pull/27105/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27105
View PR using the GUI difftool:
$ git pr show -t 27105
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27105.diff