8365953: Key manager returns no certificates when handshakeSession is not an ExtendedSSLSession

[artur-oracle]

See X509KeyManagerCertChecking#getAlgorithmConstraints. If the handshake session is not an ExtendedSSLSession, the method returns constraints using a null list of peerSupportedSignAlgs, which in turn means that all certificates will be rejected. Accepting all signature schemes would probably be a better choice here, and that's what we do when the handshake session is not available at all.

The SunJSSE SSLSockets and SSLEngines both return extended SSL sessions. There are no known third-party providers that return non-extended SSL sessions.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365953: Key manager returns no certificates when handshakeSession is not an ExtendedSSLSession (Bug - P5)

Reviewers

• Daniel Jeliński (@djelinski - Reviewer)
• Bradford Wetmore (@bradfordwetmore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27106/head:pull/27106
$ git checkout pull/27106

Update a local copy of the PR:
$ git checkout pull/27106
$ git pull https://git.openjdk.org/jdk.git pull/27106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27106

View PR using the GUI difftool:
$ git pr show -t 27106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27106.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@artur-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365953: Key manager returns no certificates when handshakeSession is not an ExtendedSSLSession

Reviewed-by: djelinski, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 279 new commits pushed to the master branch:

• 134c3ef: 8367293: RISC-V: enable vectorapi test for VectorMask.laneIsSet
• 7fcce27: 8365956: GenShen: Adaptive tenuring threshold algorithm may raise threshold prematurely
• 8599657: 8365676: javac incorrectly allows calling interface static method via type variable
• ... and 276 more: https://git.openjdk.org/jdk/compare/584137cf968bdfd4fdb88b5bb210bbbfa5f2d537...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@artur-oracle The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e27dd8f9)

[djelinski]

LGTM.

[bradfordwetmore]

I missed the changeset for 8359956. Quite a bit of work there.

LGTM also.

[artur-oracle]

/integrate

[openjdk]

Going to push as commit 4ea8979.
Since your change was applied there have been 290 commits pushed to the master branch:

• 56f2f7a: 8367138: JNI exception pending in os_getCmdlineAndUserInfo of ProcessHandleImpl_macosx.c
• a2d272a: 8367339: Parallel: Remove PSScavenge::should_scavenge
• 063f970: 8367401: Parallel: Remove unused field in PSKeepAliveClosure
• ... and 287 more: https://git.openjdk.org/jdk/compare/584137cf968bdfd4fdb88b5bb210bbbfa5f2d537...master

Your commit was automatically rebased without conflicts.

[openjdk]

@artur-oracle Pushed as commit 4ea8979.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.