8366908: Use a different class for testing JDK-8351654

[coleenp]

java.time.Duration is a migrated class (to be a value type) in the Valhalla repo, so it's preloaded, which causes this test to fail. Using a different java.base class achieves the purpose of this test.
Tested with tier1.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366908: Use a different class for testing JDK-8351654 (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer) Review applies to 0616cf65

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27116/head:pull/27116
$ git checkout pull/27116

Update a local copy of the PR:
$ git checkout pull/27116
$ git pull https://git.openjdk.org/jdk.git pull/27116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27116

View PR using the GUI difftool:
$ git pr show -t 27116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27116.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366908: Use a different class for testing JDK-8351654

Reviewed-by: liach, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the master branch:

• 03c54d4: 8365689: Elements.getFileObjectOf fails with a NullPointerException when an erroneous Element is passed in
• a272696: 8365190: Remove LockingMode related code from share
• 5e423e0: 8367025: zIndexDistributor.hpp uses angle-bracket inclusion of globalDefinitions.hpp
• ... and 128 more: https://git.openjdk.org/jdk/compare/9f70965bb9ead2268c02c688c79ec0d80574c725...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (e95eff7d)
• 01: Full - Incremental (0616cf65)
• 00: Full (b3480350)

[liach]

Isn't this println redundant, because the VerifyError is supposed to be thrown before? I think the old code uses Durations.ofHours to trigger verification and initialization of Duration.

[coleenp]

It is not reached since we throw the VerifyError at line 166.

[liach]

Thanks, looks good from a ClassFile API perspective.

[coleenp]

Thanks Chen and Leonid.

[coleenp]

Thanks Chen for re-approving.
/integrate

[openjdk]

Going to push as commit 6765a9d.
Since your change was applied there have been 133 commits pushed to the master branch:

• 166ef5e: 8366159: SkippedException is treated as a pass for pkcs11/KeyStore, pkcs11/SecretKeyFactory and pkcs11/SecureRandom
• bcff857: 8361381: GlyphLayout behavior differs on JDK 11+ compared to JDK 8
• 03c54d4: 8365689: Elements.getFileObjectOf fails with a NullPointerException when an erroneous Element is passed in
• ... and 130 more: https://git.openjdk.org/jdk/compare/9f70965bb9ead2268c02c688c79ec0d80574c725...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 6765a9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.