-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8366875: CompileTaskTimeout should be reset for each iteration of RepeatCompilation #27120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/27094
Are you sure you want to change the base?
Conversation
👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
/label add hotspot-compiler |
@mhaessig |
@mhaessig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable :)
When running a debug JVM on Linux with a compile task timeout and repeated compilation, the execution will time out almost always because the timeout does not reset for repetitions of a compilation. The core of the compile task timeout is to limit the amount of time a single compilation can take. Thus, this PR resets the
CompileTaskTimeout
for every compilation when running with-XX:RepeatCompilation=<n>
for n > 1.This PR is stacked on top of #27094.
Testing:
Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27120/head:pull/27120
$ git checkout pull/27120
Update a local copy of the PR:
$ git checkout pull/27120
$ git pull https://git.openjdk.org/jdk.git pull/27120/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27120
View PR using the GUI difftool:
$ git pr show -t 27120
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27120.diff
Using Webrev
Link to Webrev Comment