Skip to content

Conversation

mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Sep 5, 2025

When running a debug JVM on Linux with a compile task timeout and repeated compilation, the execution will time out almost always because the timeout does not reset for repetitions of a compilation. The core of the compile task timeout is to limit the amount of time a single compilation can take. Thus, this PR resets the CompileTaskTimeout for every compilation when running with -XX:RepeatCompilation=<n> for n > 1.

This PR is stacked on top of #27094.

Testing:

  • Github Actions (failures are unrelated)
  • tier1, tier2, tier3 plus some additional internal testing

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #27094 must be integrated first

Issue

  • JDK-8366875: CompileTaskTimeout should be reset for each iteration of RepeatCompilation (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27120/head:pull/27120
$ git checkout pull/27120

Update a local copy of the PR:
$ git checkout pull/27120
$ git pull https://git.openjdk.org/jdk.git pull/27120/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27120

View PR using the GUI difftool:
$ git pr show -t 27120

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27120.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into pr/27094 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@mhaessig The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot [email protected] rfr Pull request is ready for review labels Sep 5, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2025

Webrevs

@mhaessig
Copy link
Contributor Author

mhaessig commented Sep 5, 2025

/label add hotspot-compiler
/label remove hotspot

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@mhaessig
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@mhaessig
The hotspot label was successfully removed.

Copy link
Member

@dean-long dean-long left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@eme64 eme64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants