Skip to content

Conversation

magicus
Copy link
Member

@magicus magicus commented Sep 5, 2025

With DRYRUN := true, the actual command line will not be executed, but all other steps are done, to facilitate debugging.

This PR has effects on some closed Oracle code, hence the changes in the mac bundle path logic.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8246325: Add DRYRUN facility to SetupExecute (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27121/head:pull/27121
$ git checkout pull/27121

Update a local copy of the PR:
$ git checkout pull/27121
$ git pull https://git.openjdk.org/jdk.git pull/27121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27121

View PR using the GUI difftool:
$ git pr show -t 27121

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27121.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2025

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@magicus magicus force-pushed the setup-execute-dryrun branch 3 times, most recently from aac16a6 to dd1db3e Compare September 8, 2025 09:50
@magicus magicus force-pushed the setup-execute-dryrun branch from dd1db3e to 5aaf4e5 Compare September 8, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant