8370663: Incorrect synchronization in nsk/jvmti/RedefineClasses when expected events are not received

[lmesnik]

These tests nsk/jvmti/RedefineClasses
redefclass028.cpp
redefclass029.cpp
redefclass030.cpp
try to provoke compilation of certain methds and exit if CompileMethodLoad event are not received
with exit(95 + PASS)

Before exit they also try to resume java using
nsk_jvmti_resumeSync();
The java is not suspended so this resume is failing. Currently, the failure is silently ignored now but going to fail after
https://bugs.openjdk.org/browse/JDK-8352654
is fixed. This situation might happen with -Xcomp or other similar flags the might change compilation order. The complete fix would be to understand if we should run test in all modes and have strict check or throw SkippedException. But it requires much more effort.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370663: Incorrect synchronization in nsk/jvmti/RedefineClasses when expected events are not received (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27992/head:pull/27992
$ git checkout pull/27992

Update a local copy of the PR:
$ git checkout pull/27992
$ git pull https://git.openjdk.org/jdk.git pull/27992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27992

View PR using the GUI difftool:
$ git pr show -t 27992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27992.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370663: Incorrect synchronization in nsk/jvmti/RedefineClasses when expected events are not received

Reviewed-by: sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 20e55fa: 8370687: Improve before constructor has been called error message
• 86f60f6: 8351149: Remove dead IA32/X32/!AMD64 code blocks after 32-bit x86 removal
• 5ebc2c7: 8369995: Fix StringIndexOutOfBoundsException and implement extra logging and/or propagate errors in X509KeyManagerImpl
• ... and 31 more: https://git.openjdk.org/jdk/compare/e7c7892b9f0fcee37495cce312fdd67dc800f9c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e955c76a)

[sspitsyn]

This looks okay to me. Thank you for catching it!

[lmesnik]

/integrate

[openjdk]

Going to push as commit 2fc4cbe.
Since your change was applied there have been 103 commits pushed to the master branch:

• ec059c0: 8365880: Shenandoah: Unify memory usage accounting in ShenandoahFreeSet
• 1781b18: 8343232: PKCS#12 KeyStore support for RFC 9879: Use of Password-Based Message Authentication Code 1 (PBMAC1)
• 8236800: 8370527: Memory leak after 8316694: Implement relocation of nmethod within CodeCache
• ... and 100 more: https://git.openjdk.org/jdk/compare/e7c7892b9f0fcee37495cce312fdd67dc800f9c9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 2fc4cbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.