8370708: RISC-V: Add VerifyStackAtCalls

[robehn]

Hi, please consider.

Sanity tested and no issues with MAJIK t1 (with +VSC).

Thanks, Robbin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8370708: RISC-V: Add VerifyStackAtCalls (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer) 🔄 Re-review required (review applies to 257b0499)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28005/head:pull/28005
$ git checkout pull/28005

Update a local copy of the PR:
$ git checkout pull/28005
$ git pull https://git.openjdk.org/jdk.git pull/28005/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28005

View PR using the GUI difftool:
$ git pr show -t 28005

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28005.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn This change is no longer ready for integration - check the PR body for details.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (0dfed06f)
• 02: Full - Incremental (1a2059f6)
• 01: Full - Incremental (257b0499)
• 00: Full (f7242f22)

[robehn]

Fixed, thanks for having a look!

[RealFYang]

Thanks for the quick update.

[robehn]

Thanks for reviewing!

[RealFYang]

Thanks for the update. You might want to change this into st->print("sd t2, [sp, #%d]\n\t", framesize - 3 * wordSize); at the same time. BTW: My local hs:tier1 with -XX:+VerifyStackAtCalls using fastdebug build is good.

[robehn]

Oh, did I miss that, sorry!