Speed up DateTime parse & format #28790
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back swen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Contributor
Author
1. ShellWe run the following Shell command on MacBook M1 Pro # Base
git checkout 946170a65f6013716abd27ea0ca8f99e291eb204
make test TEST="micro:java.time.format.DateTimeFormatterParse"
# datetime_unroll_2512
git checkout 0025fedf8b5569fecc602708cf20b9da23fd6d5d
make test TEST="micro:java.time.format.DateTimeFormatterParse"2. Raw Benchmark Data3. Compare
|
JnRouvignac
reviewed
Dec 12, 2025
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
Outdated
Show resolved
Hide resolved
…Builder.java Co-authored-by: Jean-Noël Rouvignac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates the potential for performance optimizations in java.time.format.DateTimeFormatter parse and format.
It will be submitted as multiple smaller PRs. includes #28471
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28790/head:pull/28790$ git checkout pull/28790Update a local copy of the PR:
$ git checkout pull/28790$ git pull https://git.openjdk.org/jdk.git pull/28790/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28790View PR using the GUI difftool:
$ git pr show -t 28790Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28790.diff