8373638: RBTree public interface does not check all input parameters for validity

[caspernorrbin]

Hi everyone,

The public interface for the RBTree assumes most input is valid, and does not check for null pointers. This could lead to potential null pointer dereferences. We should instead assert to give clearer errors in debug builds and to avoid trying to dereference these null pointers.

Testing:

• Oracle tiers 1-3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373638: RBTree public interface does not check all input parameters for validity (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28922/head:pull/28922
$ git checkout pull/28922

Update a local copy of the PR:
$ git checkout pull/28922
$ git pull https://git.openjdk.org/jdk.git pull/28922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28922

View PR using the GUI difftool:
$ git pr show -t 28922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28922.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cnorrbin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@caspernorrbin The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5df5c446)

[dholmes-ora]

These all look like they would be good candidates for using precond().