Skip to content

Conversation

@apupier
Copy link

@apupier apupier commented Dec 19, 2025

Previous instruction were leading to:

sudo dnf group install "Development Tools"
Updating and loading repositories:
Repositories loaded.
Failed to resolve the transaction:
No match for argument: Development Tools
You can try to add to command line:
  --skip-unavailable to skip unavailable packages

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8374150: Fix instruction for requirements on rpm-based for building with cross-compile (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28925/head:pull/28925
$ git checkout pull/28925

Update a local copy of the PR:
$ git checkout pull/28925
$ git pull https://git.openjdk.org/jdk.git pull/28925/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28925

View PR using the GUI difftool:
$ git pr show -t 28925

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28925.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 19, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

Hi @apupier, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user apupier" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@apupier The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@apupier apupier force-pushed the fixBuildingInstructionRPMBasedLinux branch from fc91e94 to f705b4b Compare December 19, 2025 13:40
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@apupier Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@apupier apupier force-pushed the fixBuildingInstructionRPMBasedLinux branch from f705b4b to 0fe22cf Compare December 19, 2025 13:59
@apupier
Copy link
Author

apupier commented Dec 19, 2025

/covered

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@apupier Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Dec 19, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

with cross-compile

Previous instruction was leading to:
```
sudo dnf group install "Development Tools"
Updating and loading repositories:
Repositories loaded.
Failed to resolve the transaction:
No match for argument: Development Tools
You can try to add to command line:
  --skip-unavailable to skip unavailable packages
```

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier force-pushed the fixBuildingInstructionRPMBasedLinux branch from 0fe22cf to b8a3a1b Compare December 19, 2025 14:04
@apupier apupier changed the title Fix instruction for requirements on rpm-based for building with cross-compile 8374150 : Fix instruction for requirements on rpm-based for building with cross-compile Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@apupier Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.


```
sudo yum groupinstall "Development Tools"
sudo yum group install development-tools
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that it doesn't install the c++ compiler, which is marked as required when using bash configure
I'm wondering if we should not add c-development group too

sudo yum group install development-tools c-development

but it is changing a bit the scope so not sure that we need to do it here

with cross-compile

update building.html (manually because the command make
update-build-docs is failing for me locally)

Signed-off-by: Aurélien Pupier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant