-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374150 : Fix instruction for requirements on rpm-based for building with cross-compile #28925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8374150 : Fix instruction for requirements on rpm-based for building with cross-compile #28925
Conversation
|
Hi @apupier, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user apupier" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
fc91e94 to
f705b4b
Compare
|
@apupier Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
f705b4b to
0fe22cf
Compare
|
/covered |
|
@apupier Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
with cross-compile Previous instruction was leading to: ``` sudo dnf group install "Development Tools" Updating and loading repositories: Repositories loaded. Failed to resolve the transaction: No match for argument: Development Tools You can try to add to command line: --skip-unavailable to skip unavailable packages ``` Signed-off-by: Aurélien Pupier <[email protected]>
0fe22cf to
b8a3a1b
Compare
|
@apupier Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
|
||
| ``` | ||
| sudo yum groupinstall "Development Tools" | ||
| sudo yum group install development-tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that it doesn't install the c++ compiler, which is marked as required when using bash configure
I'm wondering if we should not add c-development group too
sudo yum group install development-tools c-development
but it is changing a bit the scope so not sure that we need to do it here
with cross-compile update building.html (manually because the command make update-build-docs is failing for me locally) Signed-off-by: Aurélien Pupier <[email protected]>
Previous instruction were leading to:
Progress
Error
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28925/head:pull/28925$ git checkout pull/28925Update a local copy of the PR:
$ git checkout pull/28925$ git pull https://git.openjdk.org/jdk.git pull/28925/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28925View PR using the GUI difftool:
$ git pr show -t 28925Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28925.diff