Skip to content

Conversation

@eme64
Copy link
Contributor

@eme64 eme64 commented Dec 19, 2025

Clean backport of #28783 to JDK26.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8373502: C2 SuperWord: speculative check uses VPointer variable was pinned after speculative check, leading to bad graph (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28929/head:pull/28929
$ git checkout pull/28929

Update a local copy of the PR:
$ git checkout pull/28929
$ git pull https://git.openjdk.org/jdk.git pull/28929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28929

View PR using the GUI difftool:
$ git pr show -t 28929

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28929.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

👋 Welcome back epeter! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 00050f84d44f3ec23e9c6da52bffd68770010749 8373502: C2 SuperWord: speculative check uses VPointer variable was pinned after speculative check, leading to bad graph Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler [email protected] labels Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@eme64 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@eme64 eme64 marked this pull request as ready for review December 19, 2025 15:05
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 19, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2025

Webrevs

Copy link
Contributor

@mhaessig mhaessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required hotspot-compiler [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants