-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8373819: GenShen: Requested generation may be null #28932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8373819: GenShen: Requested generation may be null #28932
Conversation
|
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@earthling-amzn The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
This PR attempts to simplify the generational control thread by decoupling it somewhat from the heap/gc cancellation mechanism. This is meant to prevent the control thread from seeing inconsistencies between
shHeap::_cancelled_gcandshGenControlThread::_requested_gc_cause.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28932/head:pull/28932$ git checkout pull/28932Update a local copy of the PR:
$ git checkout pull/28932$ git pull https://git.openjdk.org/jdk.git pull/28932/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28932View PR using the GUI difftool:
$ git pr show -t 28932Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28932.diff
Using Webrev
Link to Webrev Comment