8373718: jdk/internal/misc/VM/RuntimeArguments.java test fails in Virtual threads mode

[bchristi-git]

RuntimeArguments.java runs with @requires vm.flagless, though setting the test.thread.factory=Virtual system property with -D will still run the test.

The test spawns java processes, checking for particular, exact sets of runtime options (hence, vm.flagless). It is not expecting to find -Dtest.thread.factory=Virtual.

It doesn't seem important that this test be run with the virtual thread factory. The suggestion of adding this test to ProblemList-Virtual.txt seems reasonable. (It would be a long term resident of the problem list, which is perhaps a bit strange.)

Alternative courses of action:

• Teach the test itself to artificially pass in the presence of -D options.
• Enhance the test so it knows how to expect -D options; offhand that doesn't seem worth it.

Update:
The bots don't like having the "current" bugid present in the problem list. I have updated the bugid in the PL to 8309303 (when the VM_OPTIONS constant was added to the test) - a bit disingenuous. If we're not happy with this, I guess a new issue could be filed ("RuntimeArguments.java doesn't account for -D system properties") to use in the problem list.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373718: jdk/internal/misc/VM/RuntimeArguments.java test fails in Virtual threads mode (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28935/head:pull/28935
$ git checkout pull/28935

Update a local copy of the PR:
$ git checkout pull/28935
$ git pull https://git.openjdk.org/jdk.git pull/28935/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28935

View PR using the GUI difftool:
$ git pr show -t 28935

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28935.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bchristi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@bchristi-git To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[bchristi-git]

/label core-libs

[openjdk]

@bchristi-git
The core-libs label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (2483e66e)
• 00: Full (e14a1cec)

[AlanBateman]

It doesn't seem important that this test be run with the virtual thread factory.

In that case, can you add @requires test.thread.factory == null to the test description. That would avoid having it permanently excluded via ProblemList-Virtual.txt when doing JTREG_TEST_THREAD_FACTORY=Virtual test runs.