8374168: Resolve disabled warnings in JDWP agent #28937
Conversation
|
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@alexmenkov The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
| // PlatformThreadsFilter contains nothing useful | ||
| //PlatformThreadsFilter *filter = &FILTER(node, index).u.PlatformThreadsOnly; |
There was a problem hiding this comment.
I think you can just delete this.
| if (error != JVMTI_ERROR_NONE) { | ||
| EXIT_ERROR(error, "cannot get current thread"); | ||
| } |
There was a problem hiding this comment.
I'm not sure about his one since it is a behavior change. For example, we have:
jthread thread = threadControl_currentThread();
if ((thread != NULL) && (!threadControl_isDebugThread(thread))) {
threadControl_setPendingInterrupt(thread);
}
|
|
||
| /* To handle "format string is not a string literal" warning. */ | ||
| #if !defined(_MSC_VER) | ||
| #define ATTRIBUTE_PRINTF(fmt, vargs) __attribute__((format(printf, fmt, vargs))) |
There was a problem hiding this comment.
Why not ATTRIBUTE_FORMAT?
3 participants
The fix resolves disabled warnings in debugger agent
Progress
Issue
Reviewers without OpenJDK IDs
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28937/head:pull/28937$ git checkout pull/28937Update a local copy of the PR:
$ git checkout pull/28937$ git pull https://git.openjdk.org/jdk.git pull/28937/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28937View PR using the GUI difftool:
$ git pr show -t 28937Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28937.diff
Using Webrev
Link to Webrev Comment