8373983: java/util/Locale/UseOldISOCodesTest.java fails with JTREG_AOT_JDK=onestep

[iklam]

This test checks for a warning message that's printed by sun.util.locale.BaseLocale.<clinit> during the AOT cache training run. Because BaseLocale is AOT-initialized, BaseLocale.<clinit> is not executed when the test is running with an AOT cache, so the message is not printed.

Since this message was already printed in the AOT training run, it's not necessary to print it again in the AOT production run. We should exclude the test case in the JTREG_AOT_JDK=onestep test mode.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8373983: java/util/Locale/UseOldISOCodesTest.java fails with JTREG_AOT_JDK=onestep (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewers without OpenJDK IDs

• @khanbilal732 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28938/head:pull/28938
$ git checkout pull/28938

Update a local copy of the PR:
$ git checkout pull/28938
$ git pull https://git.openjdk.org/jdk.git pull/28938/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28938

View PR using the GUI difftool:
$ git pr show -t 28938

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28938.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373983: java/util/Locale/UseOldISOCodesTest.java fails with JTREG_AOT_JDK=onestep

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 9715e6d: 8374178: Missing include in systemDictionary.cpp after JDK-8365526
• a61a1d3: 8373525: C2: assert(_base == Long) failed: Not a Long
• 2715f5e: 8374151: Cleanup minor markWord function disorder
• ... and 7 more: https://git.openjdk.org/jdk/compare/2d0928406027a848cf2d2d0574024970b8fb535c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@iklam To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[liach]

/label core-libs,i18n,hotspot-runtime

[openjdk]

@liach
The core-libs label was successfully added.

The i18n label was successfully added.

The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (baa20465)

[naotoj]

Looks fine

[iklam]

Thanks @naotoj for the review
/integrate

[openjdk]

Going to push as commit 4b8eda3.
Since your change was applied there have been 11 commits pushed to the master branch:

• 7250542: 8374038: JDI EventRequestManager javadoc has unrendered @link tags inside an @code block
• 9715e6d: 8374178: Missing include in systemDictionary.cpp after JDK-8365526
• a61a1d3: 8373525: C2: assert(_base == Long) failed: Not a Long
• ... and 8 more: https://git.openjdk.org/jdk/compare/2d0928406027a848cf2d2d0574024970b8fb535c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@iklam Pushed as commit 4b8eda3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.