-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8372801: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 27 #28945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/28944
Are you sure you want to change the base?
Conversation
|
👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@nizarbenalla The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/label add javadoc |
|
/label remove jmx |
|
@nizarbenalla |
|
@nizarbenalla |
|
@nizarbenalla |
|
@nizarbenalla |
|
@nizarbenalla |
The test no longer needs to be problem listed now that the symbol information has caught up and is up to date.
This PR has a dependency on #28944, I want them integrate them in order.
Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28945/head:pull/28945$ git checkout pull/28945Update a local copy of the PR:
$ git checkout pull/28945$ git pull https://git.openjdk.org/jdk.git pull/28945/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28945View PR using the GUI difftool:
$ git pr show -t 28945Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28945.diff
Using Webrev
Link to Webrev Comment