8374178: Missing include in systemDictionary.cpp after JDK-8365526

[DamonFool]

Hi all,

Please review this tiny fix of missing include in systemDictionary.cpp.
For how to reproduce the error, please see the JBS.

Thanks.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374178: Missing include in systemDictionary.cpp after JDK-8365526 (Bug - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewers without OpenJDK IDs

• @khanbilal732 (no known openjdk.org user name / role) Review applies to a7789200

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28946/head:pull/28946
$ git checkout pull/28946

Update a local copy of the PR:
$ git checkout pull/28946
$ git pull https://git.openjdk.org/jdk.git pull/28946/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28946

View PR using the GUI difftool:
$ git pr show -t 28946

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28946.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DamonFool This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374178: Missing include in systemDictionary.cpp after JDK-8365526

Reviewed-by: kbarrett, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 9435d5b: 8346154: [XWayland] Some tests fail intermittently in the CI, but not locally
• 25e8714: 8369515: Deadlock between JVMTI and JNI ReleasePrimitiveArrayCritical

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DamonFool The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (b3d9eece)
• 00: Full (a7789200)

[iklam]

There's no need to put this in an #if, or else the includes will become cluttered over time. You can just put it in the regular include lines above.

[kimbarrett]

+1 - we generally conditionalize includes based on optional features or (rarely (never?) in shared code)
platforms, not on build type.

[kimbarrett]

+1 - we generally conditionalize includes based on optional features or (rarely (never?) in shared code)
platforms, not on build type.

[DamonFool]

Thanks @iklam and @kimbarrett for the comments.
Updated.

[dholmes-ora]

Trivially fine.

Just to reiterate what has been said in the past, we are not too concerned about making all possible combinations of enabled/disabled services work. If a "full" VM works and the Minimal VM works then that is normally sufficient.

[kimbarrett]

Looks good.