8345358: Some DLL Files are missing Windows Properties #611

alexeybakhtin · 2024-12-10T22:45:15Z

Add missing properties for the j2gss.dll and sspi_bridge.dll files

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8345358 needs maintainer approval

Issue

JDK-8345358: Some DLL Files are missing Windows Properties (Bug - P4 - Approved)

Reviewers

Andrew John Hughes (@gnu-andrew - Reviewer)
Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/611/head:pull/611
$ git checkout pull/611

Update a local copy of the PR:
$ git checkout pull/611
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/611/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 611

View PR using the GUI difftool:
$ git pr show -t 611

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/611.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-12-10T22:45:35Z

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-12-10T22:46:03Z

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8345358: Some DLL Files are missing Windows Properties

Reviewed-by: andrew, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

86ecd5b: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
942d6d0: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash
c0a36d8: 8366574: Bump update version of OpenJDK: 8u482
... and 97 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlbridge · 2024-12-10T22:49:13Z

Webrevs

alexeybakhtin · 2024-12-11T00:20:27Z

CI Failures are not related to the changes.

bridgekeeper · 2025-01-08T05:15:24Z

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

alexeybakhtin · 2025-01-08T05:17:31Z

Keep it open

bridgekeeper · 2025-02-05T07:37:13Z

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

alexeybakhtin · 2025-02-05T15:16:17Z

Please review

mrserb · 2025-02-25T04:02:59Z

Is it possible to create a new test to verify this change?

tkiriyama · 2025-03-05T09:05:38Z

Thank you for fixing.
I found this bug by verifying some Windows Properties of the .dll and .exe files in the binary with the PowerShell and reported it to JBS.

powershell -ExecutionPolicy Remotesigned .\PropsList.ps1 .\jdk

PropsList.ps1

$path = $Args[0]

$files = Get-ChildItem -Path $path -include *.exe,*.dll -Recurse

foreach($f in $files) {

  $out = $f.VersionInfo.FileName

  $out += ";" + $f.VersionInfo.LegalCopyright
  $out += ";" + $f.VersionInfo.CompanyName
  $out += ";" + $f.VersionInfo.FileDescription
  $out += ";" + $f.VersionInfo.FileVersion
  $out += ";" + $f.VersionInfo.ProductName
  $out += ";" + $f.VersionInfo.ProductVersion
  
  Write-Host $out
}

bridgekeeper · 2025-04-02T14:43:44Z

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

tkiriyama · 2025-04-10T01:18:29Z

This fix should be integrated.

bridgekeeper · 2025-05-08T01:34:12Z

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

mrserb · 2025-05-09T19:17:27Z

keep open

bridgekeeper · 2025-06-06T23:07:42Z

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

tkiriyama · 2025-06-16T01:10:16Z

/touch

openjdk · 2025-06-16T01:10:49Z

@tkiriyama The pull request is being re-evaluated and the inactivity timeout has been reset.

bridgekeeper · 2025-07-14T01:14:44Z

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

tkiriyama · 2025-07-17T09:17:58Z

Hi, @alexeybakhtin
The reported issue doesn't seem to be resolved yet. Would you please move forward with this pull request?

alexeybakhtin · 2025-07-22T22:33:58Z

Hi, @alexeybakhtin The reported issue doesn't seem to be resolved yet. Would you please move forward with this pull request?

There is a request to make a test. I'm not sure how to make jtreg test for this issue.

kurashige23 · 2025-08-19T05:31:10Z

Hi, @alexeybakhtin

I propose the following code, which I made based on tkiriyama`s comment, as a test for this PR fix.

jdk/test/lib/property/CheckWindowsProperty.java

/*
 * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 */

/*
 * @test
 * @summary file property check for Windows .exe/.dll
 * @requires os.family == "windows"
 */

import java.io.BufferedReader;
import java.io.InputStreamReader;

public class CheckWindowsProperty {
  public static void main(String[] args) throws Exception {
    String targetDir = System.getProperty("test.jdk") + "\\";
    String psCommand = String.format(
        "Get-ChildItem -Path '%s' -include *.exe,*.dll -Recurse -File | " +
        "ForEach-Object { " +
            "$vi = $_.VersionInfo; " +
            "@($vi.FileName, $vi.CompanyName, $vi.FileDescription, $vi.FileVersion, " +
            "$vi.InternalName, $vi.Language, $vi.LegalCopyright, $vi.OriginalFilename, " +
            "$vi.ProductName, $vi.ProductVersion) -join ';'" +
        "}",
        targetDir
    );

    ProcessBuilder pb = new ProcessBuilder("powershell", "-NoLogo", "-NoProfile",
         "-Command", psCommand).redirectErrorStream(true);
    Process p = pb.start();
    p.getOutputStream().close();

    try (BufferedReader br = new BufferedReader(new InputStreamReader(p.getInputStream()))) {
        for (String line = br.readLine(); line != null; line = br.readLine()) {
            checkFileProperty(line);
        }
    }
    p.waitFor();
    int exitCode = p.exitValue();
    if (exitCode != 0) {
        throw new RuntimeException("ExitCode is " + exitCode + ". PowerShell command failed.");
    }
  }

  static void checkFileProperty(String line) {
    // line format
    // FileName;CompanyName;FileDescription;FileVersion;InternalName;Language;LegalCopyright;
    // OriginalFilename;ProductName;ProductVersion
    String[] data = line.split(";", -1);
    String filename = data[0].substring(data[0].lastIndexOf(System.getProperty("file.separator")) + 1);

    // skip Microsoft redist dll
    if (filename.startsWith("api-ms-win") ||
        filename.startsWith("msvcp") ||
        filename.startsWith("ucrtbase") ||
        filename.startsWith("vcruntime")) {
        return;
    }

    if (filename.equals("freetype.dll") || filename.equals("sawindbg.dll")) {
        for (int i = 1; i < data.length; i++) {
            if (data[i] == null || !data[i].isEmpty()) {
                throw new RuntimeException(data[i] +" is set in data[" + i + "]. data[" + i + "] should be empty for " + filename);
            }
        }
    } else {
        for (int i = 1; i < data.length; i++) {
            if (data[i] == null || data[i].isEmpty()) {
                throw new RuntimeException("data[" + i + "] should not be empty for " + filename);
            }
        }
    }
  }
}

I confirmed that the test result is as follows:

when this PR fix is not applied

FAILED: lib/property/CheckWindowsProperty.java
Test results: failed: 1

----------System.err:(13/752)----------
java.lang.RuntimeException: data[1] should not be empty for j2gss.dll
	at CheckWindowsProperty.checkFileProperty(CheckWindowsProperty.java:88)
	at CheckWindowsProperty.main(CheckWindowsProperty.java:54)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
	at java.lang.Thread.run(Thread.java:750)

when this PR fixis applied

Passed: lib/property/CheckWindowsProperty.java
Test results: passed: 1

I hope this is helpful.

alexeybakhtin · 2025-08-19T18:33:14Z

Hi @kurashige23,

Thank you for the proposed test.
I have a small comment about freetype.dll and sawindbg.dll
I don't think it's correct that all the fields for these libraries should be empty. I tested several VMs from different vendors, and the fields are not always empty
I would suggest relaxing the test and allow empty fields for "freetype.dll" and"sawindbg.dll" libraries:

    for (int i = 1; i < data.length; i++) {
        if (data[i] == null || data[i].isEmpty()) {
            if (!filename.equals("freetype.dll") && !filename.equals("sawindbg.dll")) {
                throw new RuntimeException("data[" + i + "] should not be empty for " + filename);
            }
        }
    }

I would also add

 * @bug 8345358

to the header of the test

What do you think?

kurashige23 · 2025-08-20T02:52:38Z

I don't think it's correct that all the fields for these libraries should be empty. I tested several VMs from different vendors, and the fields are not always empty
I would suggest relaxing the test and allow empty fields for "freetype.dll" and"sawindbg.dll" libraries:

Thank you for checking with VMs from other vendors. I understand that the "freetype.dll" and "sawindbg.dll" properties change depending on the vendor, so I agree with your suggestion.

I would also add

* @bug 8345358

to the header of the test

I think it's good.

Co-authored-by: Taizo Kurashige <[email protected]>

openjdk · 2025-08-20T16:21:17Z

@alexeybakhtin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

alexeybakhtin · 2025-08-20T16:34:58Z

@mrserb @tkiriyama could you please review the test provided by @kurashige23

tkiriyama · 2025-08-25T10:02:59Z

LGTM.
@mrserb
Could you please confirm before ramp down phase on August 29?

alexeybakhtin · 2025-08-25T17:10:32Z

LGTM. @mrserb Could you please confirm before ramp down phase on August 29?

@mrserb could you please approve the review? Without it, I can not make a fix request. Thank you

gnu-andrew

It looks like what happened here is JDK-8199639 went into 11u just a month before the original JDK-8345358 that was backported to 8u. The 8199639 change created SetupJdkLibrary which was converted to SetupNativeCompilationin the backport. What we should have caught is that this is not a 1-to-1 replacement. SetupJdkLibrary is a wrapper around SetupNativeCompilation which - you've guessed it - sets the RC_FLAGS before calling SetupNativeCompilation.

I might look and see if it's feasible to backport that change, so we don't miss this again in future, but this minimal fix will solve the current issue.

openjdk · 2025-08-29T21:54:35Z

⚠️ @alexeybakhtin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

gnu-andrew · 2025-09-07T14:56:03Z

@alexeybakhtin this is just waiting for an approval request.

alexeybakhtin · 2025-09-08T17:27:30Z

@alexeybakhtin this is just waiting for an approval request.

Thank you. Just had a missprint in the label

gnu-andrew · 2025-09-15T15:25:20Z

@alexeybakhtin this is just waiting for an approval request.

Thank you. Just had a missprint in the label

Ah, no worries. If you use the /approval request command on the PR, you can avoid having to alter the bug manually.

/approve yes

openjdk · 2025-09-15T15:26:27Z

@gnu-andrew
8345358: The approval request has been approved.

alexeybakhtin · 2025-09-15T16:53:56Z

/integrate

openjdk · 2025-09-15T16:54:28Z

Going to push as commit 2b36fc1.
Since your change was applied there have been 100 commits pushed to the master branch:

86ecd5b: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
942d6d0: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash
c0a36d8: 8366574: Bump update version of OpenJDK: 8u482
... and 97 more: https://git.openjdk.org/jdk8u-dev/compare/5a4b44089f3f95b92620ef3a7b49f2390b70afaa...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-09-15T16:54:35Z

@alexeybakhtin Pushed as commit 2b36fc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added the rfr Pull request is ready for review label Dec 10, 2024

8345358: Some DLL Files are missing Windows Properties

9830a0e

Co-authored-by: Taizo Kurashige <[email protected]>

alexeybakhtin force-pushed the JDK-8345358 branch from e1561ef to 9830a0e Compare August 20, 2025 16:19

Add CheckWindowsProperty test

4aa76c2

gnu-andrew approved these changes Aug 29, 2025

View reviewed changes

mrserb approved these changes Sep 2, 2025

View reviewed changes

openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 8, 2025

openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 15, 2025

openjdk bot added the integrated Pull request has been integrated label Sep 15, 2025

openjdk bot closed this Sep 15, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2025

8345358: Some DLL Files are missing Windows Properties #611

8345358: Some DLL Files are missing Windows Properties #611

Uh oh!

Conversation

alexeybakhtin commented Dec 10, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Dec 10, 2024

Uh oh!

openjdk bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

alexeybakhtin commented Dec 11, 2024

Uh oh!

bridgekeeper bot commented Jan 8, 2025

Uh oh!

alexeybakhtin commented Jan 8, 2025

Uh oh!

bridgekeeper bot commented Feb 5, 2025

Uh oh!

alexeybakhtin commented Feb 5, 2025

Uh oh!

mrserb commented Feb 25, 2025

Uh oh!

tkiriyama commented Mar 5, 2025

Uh oh!

bridgekeeper bot commented Apr 2, 2025

Uh oh!

tkiriyama commented Apr 10, 2025

Uh oh!

bridgekeeper bot commented May 8, 2025

Uh oh!

mrserb commented May 9, 2025

Uh oh!

bridgekeeper bot commented Jun 6, 2025

Uh oh!

tkiriyama commented Jun 16, 2025

Uh oh!

openjdk bot commented Jun 16, 2025

Uh oh!

bridgekeeper bot commented Jul 14, 2025

Uh oh!

tkiriyama commented Jul 17, 2025

Uh oh!

alexeybakhtin commented Jul 22, 2025

Uh oh!

kurashige23 commented Aug 19, 2025

Uh oh!

alexeybakhtin commented Aug 19, 2025

Uh oh!

kurashige23 commented Aug 20, 2025

Uh oh!

openjdk bot commented Aug 20, 2025

Uh oh!

alexeybakhtin commented Aug 20, 2025

Uh oh!

tkiriyama commented Aug 25, 2025

Uh oh!

alexeybakhtin commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gnu-andrew left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Aug 29, 2025

Uh oh!

gnu-andrew commented Sep 7, 2025

Uh oh!

alexeybakhtin commented Sep 8, 2025

Uh oh!

gnu-andrew commented Sep 15, 2025

Uh oh!

alexeybakhtin commented Dec 10, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Dec 10, 2024 •

edited

Loading

mlbridge bot commented Dec 10, 2024 •

edited

Loading

alexeybakhtin commented Aug 25, 2025 •

edited

Loading