-
Notifications
You must be signed in to change notification settings - Fork 533
8358450: Viewport characteristics media features #1844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8358450: Viewport characteristics media features #1844
Conversation
👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request. @mstr2 please create a CSR request for issue JDK-8358450 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
Webrevs
|
Implementation of viewport characteristics media features:
width
height
aspect-ratio
: width / heightorientation
:portrait
,landscape
display-mode
:fullscreen
,standalone
(note:browser
andminimal-ui
are not supported in JavaFX)/reviewers 2
/csr
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1844/head:pull/1844
$ git checkout pull/1844
Update a local copy of the PR:
$ git checkout pull/1844
$ git pull https://git.openjdk.org/jfx.git pull/1844/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1844
View PR using the GUI difftool:
$ git pr show -t 1844
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1844.diff
Using Webrev
Link to Webrev Comment