8364547: Window size may be incorrect when constrained to min or max #1870
Conversation
|
👋 Welcome back mfox! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Webrevs
|
| if (minMaxEnforced) { | ||
| notifyResize(WindowEvent.RESIZE, pw, ph); | ||
| } |
There was a problem hiding this comment.
Could this lead to two resize commands in some cases? I can see why this new logic is needed for the case where the window was already at max (or min) width and height, but if it wasn't already constrained, wouldn't the resize event have already happened?
There was a problem hiding this comment.
The issue is that the Java side updates the property first, and only afterward requests the Glass native side to apply the change. I've found this to cause many problems and I fixed the same way in #1789 - when the change can't be applied, it notifies back.
There was a problem hiding this comment.
Could this lead to two resize commands in some cases?
Yes, I was trying not to be too clever with my checks. I figured if the second notification wasn't necessary it would be benign. At the very least it won't trigger invalidation of the window's width and height properties.
I will tighten this up since I have to tweak the code a bit anyway. I just verified that on Windows you can alter the size of a maximized window and the OS will keep it in the MAXIMIZED state (as it resizes glass calls notifyResize with WindowEvent.MAXIMIZED). This PR can kick the window out of the MAXIMIZED or MINIMIZED state incorrectly. Unfortunately it puts the window in the wrong internal state without updating the maximized or iconified properties so it's not easy to write a test to detect this.
|
/reviewers 2 |
|
@kevinrushforth |
|
@beldenfox This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@beldenfox The pull request is being re-evaluated and the inactivity timeout has been reset. |
When changing the width and height of a window the platform code is responsible for enforcing the min and max size constraints. If the final width and height don't match the width and height passed into setBounds the platform needs to call notifyResize to correct the window's properties. This happens naturally if the window size actually changes since that will trigger the OS to send size change notifications. If the platform window size doesn't change the OS notifications won't trigger. We need to catch that case and send notifyResize anyway.
This PR does this for Mac and Windows. Linux is being handled in PR #1789 which also includes the system tests for these bugs.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1870/head:pull/1870$ git checkout pull/1870Update a local copy of the PR:
$ git checkout pull/1870$ git pull https://git.openjdk.org/jfx.git pull/1870/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1870View PR using the GUI difftool:
$ git pr show -t 1870Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1870.diff
Using Webrev
Link to Webrev Comment