Skip to content

8360940: Layout stops updating when using Parent#setNeedsLayout(true) due to incorrect state management #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8360940: Layout stops updating when using Parent#setNeedsLayout(true) due to incorrect state management #1879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31cbd54
Propagate forceParentLayout flag to prevent inconsistent layout state
hjohn Aug 23, 2025
59b5f28
Remove trailing whitespace
hjohn Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modules/javafx.graphics/src/main/java/javafx/scene/Parent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ private void markDirtyLayout(boolean local, boolean forceParentLayout) {
* rendered. This is batched up asynchronously to happen once per
* "pulse", or frame of animation.
* <p>
* If this parent is either a layout root or unmanaged, then it will be
* If this parent is either a scene root or unmanaged, then it will be
* added directly to the scene's dirty layout list, otherwise requestParentLayout
* will be invoked.
* @since JavaFX 8.0
Expand Down Expand Up @@ -1066,7 +1066,15 @@ void requestParentLayout(boolean forceParentLayout) {
if (!layoutRoot) {
final Parent p = getParent();
if (p != null && (!p.performingLayout || forceParentLayout)) {
p.requestLayout();

/*
* The forceParentLayout flag must be propagated to mark all ancestors
* as needing layout. Failure to do so while performingLayout is true
* would stop the propagation mid-tree. This leaves some nodes as needing
* layout, while its ancestors are clean, which is an inconsistent state.
*/

p.requestLayout(forceParentLayout);
}
}
}
Expand Down