8366568: Allow replacing built in application menu in system menu bar #1881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an API for replacing the application menu that JavaFX places in the system menu bar on macOS. The application menu is the one next to the Apple menu that is titled with the application's name and contains the Quit menu item. The JavaFX version of this menu has many limitations so this PR allows a developer to simply replace it outright.
Technically there’s no reason to restrict this to only one menu so the API allows the developer to specify an observable list of Menus known as the common system menus. Like the current application menu the common menus are present for all JavaFX windows and remain present even if all windows lose focus. Any per-window menus provided by a MenuBar with useSystemMenuBar set will appear alongside the common system menus.
In addition the PR provides some calls that allow a developer to implement the Hide , Hide Others, and Show All menu items that are expected in the application menu.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1881/head:pull/1881
$ git checkout pull/1881
Update a local copy of the PR:
$ git checkout pull/1881
$ git pull https://git.openjdk.org/jfx.git pull/1881/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1881
View PR using the GUI difftool:
$ git pr show -t 1881
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1881.diff
Using Webrev
Link to Webrev Comment