-
Notifications
You must be signed in to change notification settings - Fork 546
8367374: JavaFX debug builds fail on Windows #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into |
|
@jaybhaskar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Reviewers: @kevinrushforth @HimaBinduMeda /reviewers 2 |
|
@kevinrushforth |
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Build passes in debug mode and in normal (release) mode.
|
Changes look fine. Verified debug build on local windows platform |
|
/integrated |
|
@jaybhaskar Unknown command |
|
/integrate |
|
Going to push as commit 49bece0.
Your commit was automatically rebased without conflicts. |
|
@jaybhaskar Pushed as commit 49bece0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport jfx25u |
|
@jaybhaskar the backport was successfully created on the branch backport-jaybhaskar-49bece0a-master in my personal fork of openjdk/jfx25u. To create a pull request with this backport targeting openjdk/jfx25u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx25u: |
Issue: data_as_asm tool fails to generate cpp object from ICU symbols file when webkit builds in debug mode.
Solution: The ICU third party lib already using MSVC to build , Make ICU build in Release mode.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1901/head:pull/1901$ git checkout pull/1901Update a local copy of the PR:
$ git checkout pull/1901$ git pull https://git.openjdk.org/jfx.git pull/1901/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1901View PR using the GUI difftool:
$ git pr show -t 1901Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1901.diff
Using Webrev
Link to Webrev Comment