Skip to content

Conversation

@jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Sep 14, 2025

Issue: data_as_asm tool fails to generate cpp object from ICU symbols file when webkit builds in debug mode.
Solution: The ICU third party lib already using MSVC to build , Make ICU build in Release mode.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8367374: JavaFX debug builds fail on Windows (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1901/head:pull/1901
$ git checkout pull/1901

Update a local copy of the PR:
$ git checkout pull/1901
$ git pull https://git.openjdk.org/jfx.git pull/1901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1901

View PR using the GUI difftool:
$ git pr show -t 1901

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1901.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2025

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 14, 2025

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367374: JavaFX debug builds fail on Windows

Reviewed-by: kcr, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Sep 14, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2025

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @HimaBinduMeda

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review September 15, 2025 12:10
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build passes in debug mode and in normal (release) mode.

@HimaBinduMeda
Copy link
Contributor

Changes look fine. Verified debug build on local windows platform

@openjdk openjdk bot added the ready Ready to be integrated label Sep 17, 2025
@jaybhaskar
Copy link
Member Author

/integrated

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

@jaybhaskar Unknown command integrated - for a list of valid commands use /help.

@jaybhaskar
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

Going to push as commit 49bece0.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 17, 2025
@openjdk openjdk bot closed this Sep 17, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 17, 2025
@openjdk
Copy link

openjdk bot commented Sep 17, 2025

@jaybhaskar Pushed as commit 49bece0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaybhaskar
Copy link
Member Author

/backport jfx25u

@openjdk
Copy link

openjdk bot commented Sep 19, 2025

@jaybhaskar the backport was successfully created on the branch backport-jaybhaskar-49bece0a-master in my personal fork of openjdk/jfx25u. To create a pull request with this backport targeting openjdk/jfx25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 49bece0a from the openjdk/jfx repository.

The commit being backported was authored by Jay Bhaskar on 17 Sep 2025 and was reviewed by Kevin Rushforth and Hima Bindu Meda.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx25u:

$ git fetch https://github.com/openjdk-bots/jfx25u.git backport-jaybhaskar-49bece0a-master:backport-jaybhaskar-49bece0a-master
$ git checkout backport-jaybhaskar-49bece0a-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx25u.git backport-jaybhaskar-49bece0a-master

@jaybhaskar jaybhaskar deleted the windebug branch September 20, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants