Skip to content

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Sep 15, 2025

Updated SQLite to v 3.50.4. verified build on all platforms. No issue seen


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1903/head:pull/1903
$ git checkout pull/1903

Update a local copy of the PR:
$ git checkout pull/1903
$ git pull https://git.openjdk.org/jfx.git pull/1903/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1903

View PR using the GUI difftool:
$ git pr show -t 1903

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1903.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2025

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366744: Update SQLite to 3.50.4

Reviewed-by: sykora, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Sep 15, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2025

Webrevs

@kevinrushforth kevinrushforth self-requested a review September 15, 2025 12:10
@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen

/reviewers 2

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds ran fine.

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Sanity test passed.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to be integrated rfr Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants