Skip to content

8360653: [lworld] LayoutIterationTest.java fails with -XX:ForceNonTearable=* #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

liach
Copy link
Member

@liach liach commented Jul 8, 2025

Mark this test as flagless so we will skip it with any layout perturbation.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8360653: [lworld] LayoutIterationTest.java fails with -XX:ForceNonTearable=* (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1505/head:pull/1505
$ git checkout pull/1505

Update a local copy of the PR:
$ git checkout pull/1505
$ git pull https://git.openjdk.org/valhalla.git pull/1505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1505

View PR using the GUI difftool:
$ git pr show -t 1505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1505.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360653: [lworld] LayoutIterationTest.java fails with -XX:ForceNonTearable=*

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • 7e4c1bc: 8361082: [lworld] RewriteBytecodesInlineTest fails with SIGSEGV
  • 680efc4: 8361250: [lworld] use more IRNode regexes in valhalla IR tests
  • 64ba13b: 8361166: [lworld] TestG1BarrierGeneration still fails after JDK-8343420

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@liach
Copy link
Member Author

liach commented Aug 5, 2025

Guess people don't bother to review this. I will just integrate.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

Going to push as commit 67e6bcc.
Since your change was applied there have been 130 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 5, 2025
@openjdk openjdk bot closed this Aug 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@liach Pushed as commit 67e6bcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant