Remove ensure_objArray and copying code and write a test

[coleenp]

This is the diff for removing copy_flatArray_to_objArray and ensure_objArray. This is relative to lworld but should apply cleanly to your PR Fred. I tested it against the tier1 tests in the lworld repo (in progress).

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Frederic Parain (@fparain - Committer)
• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1507/head:pull/1507
$ git checkout pull/1507

Update a local copy of the PR:
$ git checkout pull/1507
$ git pull https://git.openjdk.org/valhalla.git pull/1507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1507

View PR using the GUI difftool:
$ git pr show -t 1507

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1507.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Remove ensure_objArray and copying code and write a test

Reviewed-by: fparain, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 131 new commits pushed to the lworld branch:

• 57a9aef: 8364034: [lworld] Pre-register boxing classes in class loaders
• b2e518b: 8357785: [lworld] TestResolvedJavaType fails due to unexpected getInstanceFields order
• 5e55eda: 8354404: [lworld] compiler/startup/StartupOutput.java crashes during AdapterHandlerLibrary::initialize() due to too little CodeCacheSize
• ... and 128 more: https://git.openjdk.org/valhalla/compare/ed2a03e0f3001f7c5540e187328da7b07d71a957...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[liach]

Note these two paths are only used by Constructor::newInstance and Method::invoke if system property -Djdk.reflect.useNativeAccessorOnly=true is set.

[mlbridge]

Webrevs

• 00: Full (4709e337)

[coleenp]

Note these two paths are only used by Constructor::newInstance and Method::invoke if system property -Djdk.reflect.useNativeAccessorOnly=true is set.

Yes, my test passes at property.

[liach]

Looks great

[coleenp]

Thanks for reviewing, Fred and Chen.
/integrate

[openjdk]

Going to push as commit 79618d4.
Since your change was applied there have been 131 commits pushed to the lworld branch:

• 57a9aef: 8364034: [lworld] Pre-register boxing classes in class loaders
• b2e518b: 8357785: [lworld] TestResolvedJavaType fails due to unexpected getInstanceFields order
• 5e55eda: 8354404: [lworld] compiler/startup/StartupOutput.java crashes during AdapterHandlerLibrary::initialize() due to too little CodeCacheSize
• ... and 128 more: https://git.openjdk.org/valhalla/compare/ed2a03e0f3001f7c5540e187328da7b07d71a957...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 79618d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.