8371382: [lworld] Javac accepts field initializer that refers to a superclass field

[vicente-romero-oracle]

Javac is accepting this code:

abstract value class ValueParent {
    int b = 5;
}

value class ValueClass extends ValueParent {
    int a = b;
}

This is not allowed as in value classes field initializers will run in the prologue phase where references to super class fields are forbidden

TIA

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8371382: [lworld] Javac accepts field initializer that refers to a superclass field (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer) ⚠️ Review applies to e0aa3646

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1728/head:pull/1728
$ git checkout pull/1728

Update a local copy of the PR:
$ git checkout pull/1728
$ git pull https://git.openjdk.org/valhalla.git pull/1728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1728

View PR using the GUI difftool:
$ git pr show -t 1728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1728.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371382: [lworld] Javac accepts field initializer that refers to a superclass field

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the lworld branch:

• 58d748e: 8371898: [lworld] CLONE - BasicImageReader getEntryNames() is stateful and cannot be called more than once
• 409f56a: 8367245: [lworld] C2 compilation fails with "Missed optimization opportunity in PhaseIterGVN"
• 2db9fd1: 8367258: [lworld] Crash with -XX:+DeoptimizeNMethodBarriersALot due to wrongly skipping buffering of inline type receiver
• ... and 4 more: https://git.openjdk.org/valhalla/compare/4eb04ffaa626c687e294731b74b8b8cf21b7e564...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 02: Full - Incremental (9ba227c5)
• 01: Full - Incremental (e0aa3646)
• 00: Full (e73c8d8a)

[liach]

Looks reasonable

[vicente-romero-oracle]

Looks reasonable

thanks for the review