Skip to content

Fix wording related to handles vs DOIs #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

Fix wording related to handles vs DOIs #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9070c1
Update doi_checker_spec.rb
danielskatz Jul 4, 2025
85c6c58
Update doi_checker.rb
danielskatz Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/lib/doi_checker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def similar?(string_1, string_2)

def acm_105555_prefix(entry)
if entry.has_field?('doi') && entry.doi.include?("10.5555/")
{ validity: :invalid, msg: "#{entry.doi} is INVALID - 10.5555 is a known broken prefix, replace with https://dl.acm.org/doi/{doi} in the {url} field" }
{ validity: :invalid, msg: "#{entry.doi} is INVALID - 10.5555 is not a DOI prefix, but rather a handle prefix. Please replace the {doi} field with a {url} field that resolves in a browser" }
elsif entry.has_field?('url') && entry.url.include?("https://dl.acm.org/doi/10.5555")
{ validity: :skip, msg: "#{entry.url} - non-DOI with 10.5555 correctly placed in the url field, editor should ensure this resolves" }
else
Expand Down
2 changes: 1 addition & 1 deletion spec/doi_checker_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
expect(doi_summary[:ok]).to be_empty
expect(doi_summary[:missing]).to be_empty
expect(doi_summary[:skip]).to be_empty
expect(doi_summary[:invalid][0]).to include("is INVALID - 10.5555 is a known broken prefix, replace with https://dl.acm.org/doi/")
expect(doi_summary[:invalid][0]).to include("is INVALID - 10.5555 is not a DOI prefix, but rather a handle prefix. Please replace the {doi} field with a {url} field that resolves in a browser.")
end
end

Expand Down
Loading