Add CDS Rate object to MDS #918
Open
+13
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When developing CDS we came up with a more expansive definition of rates [1] to better capture real life scenarios. This commit brings that same definition to MDS, but keeps the MDS field rate_applies_when for specifying when the rate applies to an event. As in CDS, a policy rule may now contain an array of rates specifying monetary charges or subsidies for events that match that rule. This removes the need to create multiple rules on a policy to capture different parts of the rate calculation, it can all be contained in the rate array. [1]: https://github.com/openmobilityfoundation/curb-data-specification/tree/1.0.0/curbs#rate
|
I like this proposal and think it's needed. But will have to wait for a 3.0 release since it's breaking. At the moment we are focused on 2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain pull request
When developing CDS we came up with a more expansive definition of rates 1 to better capture real life scenarios. This commit brings that same definition to MDS, but keeps the MDS field rate_applies_when for specifying when the rate applies to an event.
As in CDS, a policy rule may now contain an array of rates specifying monetary charges or subsidies for events that match that rule. This removes the need to create multiple rules on a policy to capture different parts of the rate calculation, it can all be contained in the rate array.
Is this a breaking change
Impacted Spec
policyAdditional context
Closes #785.