Add ReplaceIfElseWithTernary #691
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timtebeek
commented
Aug 6, 2025
timtebeek
commented
- Fixes Recipe to replace trivial if statements with ternary operator #683
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+95
to
+97
| J.Assignment result = template.apply(getCursor(), i.getCoordinates().replace(), | ||
| thenAssign.getVariable(), | ||
| i.getIfCondition().getTree(), |
There was a problem hiding this comment.
Suggested change
| J.Assignment result = template.apply(getCursor(), i.getCoordinates().replace(), | |
| thenAssign.getVariable(), | |
| i.getIfCondition().getTree(), | |
| return template.apply(getCursor(), i.getCoordinates().replace(), |
| J.Identifier id1 = (J.Identifier) a1.getVariable(); | ||
| J.Identifier id2 = (J.Identifier) a2.getVariable(); | ||
| return id1.getSimpleName().equals(id2.getSimpleName()); | ||
| } else if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { |
There was a problem hiding this comment.
Suggested change
| } else if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { | |
| } | |
| if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { |
Reordered examples in examples.yml and added ReplaceIfElseWithTernary example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Comment on lines
+95
to
+97
| J.Assignment result = template.apply(getCursor(), i.getCoordinates().replace(), | ||
| thenAssign.getVariable(), | ||
| i.getIfCondition().getTree(), |
There was a problem hiding this comment.
Suggested change
| J.Assignment result = template.apply(getCursor(), i.getCoordinates().replace(), | |
| thenAssign.getVariable(), | |
| i.getIfCondition().getTree(), | |
| return template.apply(getCursor(), i.getCoordinates().replace(), |
| J.Identifier id1 = (J.Identifier) a1.getVariable(); | ||
| J.Identifier id2 = (J.Identifier) a2.getVariable(); | ||
| return id1.getSimpleName().equals(id2.getSimpleName()); | ||
| } else if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { |
There was a problem hiding this comment.
Suggested change
| } else if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { | |
| } | |
| if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { |
Comment on lines
+73
to
+76
| // Check if both statements are assignments to the same variable | ||
| if (!(thenStatement instanceof J.Assignment) || !(elseStatement instanceof J.Assignment)) { | ||
| return i; | ||
| } |
There was a problem hiding this comment.
This could possibly also handle return statements.
Could be done in a separate PR though.
| } else if (a1.getVariable() instanceof J.FieldAccess && a2.getVariable() instanceof J.FieldAccess) { | ||
| J.FieldAccess fa1 = (J.FieldAccess) a1.getVariable(); | ||
| J.FieldAccess fa2 = (J.FieldAccess) a2.getVariable(); | ||
| return fa1.toString().equals(fa2.toString()); |
There was a problem hiding this comment.
Not sure if we should be comparing toStrings.
| } | ||
|
|
||
| // Check if expression contains a ternary operator | ||
| boolean[] hasTernary = {false}; |
There was a problem hiding this comment.
The array seems like a hack. AtomicBoolean would be clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.