Skip to content

Conversation

dcsekar
Copy link
Contributor

@dcsekar dcsekar commented Aug 11, 2025

What's changed?

Added check for the GAV match provided in except parameter even for the dependencies in dependencyManagement.
We have requirement to exclude some set of dependencies from getting removed even if it has the lower version. But though the GAVs to be excluded passed in the except parameter, still those dependencies are getting removed if it's under the dependencyManagement.
This change is done to exclude those GAVs in dependencyManagement if it's provided in the except parameter.

What's your motivation?

This is created to address the problem mentioned in this enhance request

Anything in particular you'd like reviewers to focus on?

Reviews can check for additional check on the exception that can come in dependencyManagement.

Have you considered any alternatives or workarounds?

No.

Checklist

  • I've added unit tests to check whether the GAVs passed in except paraemter are not getting removed in dependencyManagement.

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, yes. Thanks a lot for the isolated fix!

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Sep 1, 2025
@timtebeek timtebeek added enhancement New feature or request recipe Requested Recipe labels Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recipe Requested Recipe
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants