-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Enhance terms lookup query to take a query clause #18195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance terms lookup query to take a query clause #18195
Conversation
❌ Gradle check result for 085edf2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/query/TermsQueryBuilder.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for edfa605: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f7146ff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 90f90c7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 997ddbe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9c85868: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6f52602: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
da0ba03
to
964f452
Compare
…use rather than docId Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
…checks and updated unit tests Signed-off-by: Srikanth Padakanti <[email protected]>
…checks and updated unit tests Signed-off-by: Srikanth Padakanti <[email protected]>
…checks and updated unit tests Signed-off-by: Srikanth Padakanti <[email protected]>
…checks and updated unit tests Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
964f452
to
6ab5410
Compare
❌ Gradle check result for 6ab5410: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Srikanth Padakanti <[email protected]>
❌ Gradle check result for 101c8ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for a1d7082: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
Signed-off-by: Srikanth Padakanti <[email protected]>
❌ Gradle check result for 87ec917: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2774f72: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2774f72: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/query/TermsQueryBuilder.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Srikanth Padakanti <[email protected]>
❕ Gradle check result for ae9d422: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…#18195) Signed-off-by: Srikanth Padakanti <[email protected]> Signed-off-by: Srikanth Padakanti <[email protected]> Co-authored-by: Srikanth Padakanti <[email protected]> Signed-off-by: sunqijun.jun <[email protected]>
…#18195) Signed-off-by: Srikanth Padakanti <[email protected]> Signed-off-by: Srikanth Padakanti <[email protected]> Co-authored-by: Srikanth Padakanti <[email protected]>
Description
Enhances the Terms lookup query to accept a query clause instead of only supporting a single docId. This expands functionality by enabling users to define document matches through flexible query logic rather than relying solely on fixed document IDs.
This change includes:
Support for Terms lookup query to use a query clause.
Validation logic to prevent using both id and query simultaneously.
Associated unit test updates to cover query-based lookup behavior.
Related Issues
Resolves #17599
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.